VMR move constants #223
VMR move constants #223
Conversation
|
@aehart marked this as a draft as I wasn't sure if I should wait until the fw synch has been merged? |
|
@carriganm95 would you mind checking that I have moved everything you wanted me to move? Note that I also moved/changed some constants that were in the VMRouterCM.h file: don't know if that will affect the future emulation or not. |
|
CI fails because current test vectors sometimes contain 108 processed stubs while the VMRs only can do 107 now. Will be fixed with the fw synch. |
This works on the future SW side. thanks |
meisonlikesicecream
force-pushed
the
vmr_move_constants
branch
from
826fe3e to
08c3737
Compare
meisonlikesicecream
changed the base branch from
master
to
fw_sync_12_0_0_pre4
aehart
force-pushed
the
fw_sync_12_0_0_pre4
branch
from
f6f8b64 to
8139170
Compare
meisonlikesicecream
force-pushed
the
vmr_move_constants
branch
from
08c3737 to
0e8a7e1
Compare
aehart
force-pushed
the
fw_sync_12_0_0_pre4
branch
from
c327f41 to
f1a2dc6
Compare
aehart
force-pushed
the
vmr_move_constants
branch
from
0e8a7e1 to
d45d94c
Compare
There was a problem hiding this comment.
@meisonlikesicecream Thank you for the well-written code. Approved!
As requested, moved some VMR constants from top-level files to the parameters files. Also moved some constants to the Constants.h file.
While changing the top-level files, I also cleaned up the generate_VMR* scripts and fixed some bugs.
Added implementation for testing all VMRs when running the tcl scripts. All modules pass CSim using the new testvectors in #220 (haven't tried it for the current ones).