Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update palette #24

Merged
merged 12 commits into from
Jan 31, 2024
Merged

Update palette #24

merged 12 commits into from
Jan 31, 2024

Conversation

ttedeschi
Copy link
Contributor

@ttedeschi ttedeschi commented Jan 26, 2024

This PR enforces Petroff's color schemes for 1D stack plots via the cmsDrawStack method, and viridis palette for 2D histograms via the SetCMSPalette method

@ttedeschi ttedeschi marked this pull request as draft January 26, 2024 15:47
@ttedeschi ttedeschi marked this pull request as ready for review January 29, 2024 08:58
Copy link
Member

@clelange clelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I left some comments in the code.

src/cmsstyle/cmsstyle.py Outdated Show resolved Hide resolved
src/cmsstyle/cmsstyle.py Outdated Show resolved Hide resolved
src/cmsstyle/cmsstyle.py Show resolved Hide resolved
@clelange
Copy link
Member

LGTM

@clelange clelange merged commit bca5c24 into cms-cat:master Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants