Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] specify wrong checksum #4

Closed
wants to merge 1 commit into from

Conversation

kpedro88
Copy link
Contributor

This is a test PR to ensure that the unit test added in cms-sw/cmssw#43696 triggers as intended on cms-data PRs. not to be merged

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for branch main.

@fwyzard, @cmsbuild, @smuzaffar, @makortel, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 30, 2024

cms-bot internal usage

@kpedro88 kpedro88 mentioned this pull request Jan 30, 2024
17 tasks
@kpedro88
Copy link
Contributor Author

let's wait to test until the next IB is available

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

smuzaffar commented Jan 31, 2024

@kpedro88 , unit test for version check passed but looks like the cfg_versioncheck function is only checking the top level files. You need to recursively check all the sub-directories.

Can you please add some print statements about which config files it has processed?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62a0db/37123/summary.html
COMMIT: c8708c3
CMSSW: CMSSW_14_0_X_2024-01-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/HeterogeneousCore-SonicTriton/4/37123/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@kpedro88
Copy link
Contributor Author

@smuzaffar it was actually an issue related to symbolic links. I will fix this (and add an option for verbose printouts as requested) in cms-sw/cmssw#43814 (which already includes other various bug fixes). We can leave this PR open to test the fixed script once it's merged.

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62a0db/37380/summary.html
COMMIT: c8708c3
CMSSW: CMSSW_14_1_X_2024-02-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/HeterogeneousCore-SonicTriton/4/37380/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestHeterogeneousCoreSonicTritonVersionCheck had ERRORS

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 57 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3247438
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3247410
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 19061.808 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 14102.535 KiB TrackerPhase2OTStub/Stubs
  • DQMHistoSizes: changed ( 23234.0,... ): -14102.286 KiB SiOuterTracker/Stubs
  • DQMHistoSizes: changed ( 23234.0,... ): 14027.626 KiB TrackerPhase2TTCluster/Clusters
  • DQMHistoSizes: changed ( 23234.0,... ): -14027.360 KiB SiOuterTracker/Clusters
  • DQMHistoSizes: changed ( 23234.0,... ): 3178.168 KiB TrackerPhase2OTStubV/Stub_RZ
  • DQMHistoSizes: changed ( 23234.0,... ): -25.679 KiB SiOuterTrackerV/Tracks
  • DQMHistoSizes: changed ( 23234.0,... ): 20.667 KiB TrackerPhase2OTL1TrackV/Resolution
  • DQMHistoSizes: changed ( 23234.0,... ): 16.476 KiB TrackerPhase2OTL1Track/Tracks
  • DQMHistoSizes: changed ( 23234.0,... ): -16.163 KiB SiOuterTracker/Tracks
  • DQMHistoSizes: changed ( 23234.0,... ): 2.961 KiB TrackerPhase2OTL1TrackV/Efficiency
  • DQMHistoSizes: changed ( 23234.0 ): ...
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 5 / 46 workflows

@kpedro88
Copy link
Contributor Author

Test works! Output, for the record:

 ===== Test "TestHeterogeneousCoreSonicTritonVersionCheck" ====
Traceback (most recent call last):
  File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-02-12-1100/bin/el8_amd64_gcc12/cmsTritonConfigTool", line 461, in <module>
    args.func(args)
  File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-02-12-1100/bin/el8_amd64_gcc12/cmsTritonConfigTool", line 357, in cfg_versioncheck
    raise RuntimeError("\n".join(msg+instr))
RuntimeError: 
The following files have incorrect checksum(s), indicating existing model file(s) have been changed, which violates policy:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-02-12-1100/external/el8_amd64_gcc12/data/HeterogeneousCore/SonicTriton/data/models/ragged_io/config.pbtxt

To override incorrect checksums, run the following command (and provide a justification in your PR):
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-02-12-1100/bin/el8_amd64_gcc12/cmsTritonConfigTool versioncheck --update --force

---> test TestHeterogeneousCoreSonicTritonVersionCheck had ERRORS
TestTime:12
^^^^ End Test TestHeterogeneousCoreSonicTritonVersionCheck ^^^^

@kpedro88 kpedro88 closed this Feb 13, 2024
@makortel
Copy link

Thanks Kevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants