Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML cofing files for the OMTF displaced algo. #26

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

akalinow
Copy link
Contributor

XML configuration files that will be used with an updated version of the OMTF emulator. The emulator code PR will follow this PR in a few weeks.

* add patterns version compatible with displaced algo
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 23, 2023

A new Pull Request was created by @akalinow (Artur Kalinowski) for branch master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @epalencia, @aloeliger, @iarspider can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@akalinow
Copy link
Contributor Author

adding @mbluj @kbunkow as observers

@cmsbuild
Copy link
Contributor

Pull request #26 was updated.

@aloeliger
Copy link

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a66396/36172/summary.html
COMMIT: 2550ed5
CMSSW: CMSSW_14_0_X_2023-11-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-L1TMuon/26/36172/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@aloeliger
Copy link

@akalinow Was the PR that corresponds to this ever made/merged?

@aloeliger
Copy link

+l1

@akalinow
Copy link
Contributor Author

Yes, the corresponding PR to CMSSW are 43687 1196

@aloeliger
Copy link

Okay, perfect, thanks.

@smuzaffar
Copy link
Contributor

+externals

only new data files but this should be merged along with cms-sw/cmssw#43687

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @antoniovilela, @rappoccio: This PR was tested with cms-sw/cmssw#43687, please check if they should be merged together

@antoniovilela
Copy link

+1

@antoniovilela
Copy link

ping bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants