Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ParticleNet files in structure needed for SONIC #48

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

wpmccormack
Copy link
Contributor

This is a companion PR to cms-sw/cmssw#37964. We are adding a SONIC producer for ParticleNet (AK4, AK8 General, Mass Decorrelation, and MassRegression) to CMSSW to do some production tests. Nominally SONIC is designed to enable easy use of co-processors in CMS workflows, but it can also start up CPU-based inference servers within jobs. This PR does not affect any workflow in CMS in any way unless called specifically (the SONIC producer is independent of the generic ParticleNet one). The SONIC framework requires the model files and a specifically formatted config file for the Triton server, and these are contained in this PR in the structure required by NVIDIA Triton. Please refer to these slides for more information about SONIC and our use of NVIDIA Triton: https://indico.cern.ch/event/1143469/contributions/4799423/attachments/2416540/4135308/March_28_JetMET_SONIC.pdf. Note that both ONNX and PyTorch versions of the models are included - SONIC greatly simplifies the running of PyTorch models for CMS

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wpmccormack (Patrick McCormack) for branch master.

@smuzaffar, @aandvalenzuela, @iarspider, @clacaputo, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks.
@JyothsnaKomaragiri, @emilbols, @demuller, @andrzejnovak, @AlexDeMoor this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #48 was updated.

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 1, 2022

can you change " particlenet_modelsForSonic" to something more concise, like just "models"?

It's also not clear to me how well the symlink scheme here (which is different from DeepMET) will work with Eras, but I guess right now there isn't an example case of Era usage with ParticleNet.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2022

Pull request #48 was updated.

@wpmccormack
Copy link
Contributor Author

I changed the directory to "models"

@perrotta
Copy link

merge

  • Tested together with #37964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants