-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove model files of depreciated tauIds. #9
Remove model files of depreciated tauIds. #9
Conversation
A new Pull Request was created by @mbluj for branch master. @smuzaffar, @aandvalenzuela, @iarspider, @clacaputo, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks. |
please test with cms-sw/cmssw#38063 |
Differences in reco outputs are due to the additional merge commits added while running this PR. Please @cms-sw/reconstruction-l2 have a look and sign, if you have nothing against this removal of now unused data files |
+externals |
@jpata @clacaputo : it is certainly not urgent, but if you agree with removing these data files after the removal of the tauIds which were using them (by the already merged cms-sw/cmssw#38164), please let us know by signing this PR |
+reconstruction |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
ping bot |
As title says, this PR removes model files of depreciated tauIds: DPFIsolation v0 and v1, and DeepTauId v1.
This PR complements cms-sw/cmssw#38063.