Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add values for new member bool IterationParams::recheckOverlap. #13

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

osschar
Copy link
Contributor

@osschar osschar commented Dec 12, 2023

These JSON changes go along with trackreco/cmssw#118

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2023

A new Pull Request was created by @osschar (Matevž Tadel) for branch main.

@aandvalenzuela, @iarspider, @cmsbuild, @smuzaffar, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@slava77
Copy link

slava77 commented Dec 12, 2023

These JSON changes go along with trackreco/cmssw#118

@osschar
this PR is in a general cms-data repo; was it intended to be made here or in the trackreco as well?

@osschar
Copy link
Contributor Author

osschar commented Dec 12, 2023

Oh, yes, I wanted it to go to trackreco, sorry about that.
Presumably this will become useful here as well -- so let's just put it on hold for now.
I created a separate trackreco one, trackreco#2

@cmsbuild
Copy link
Contributor

Pull request #13 was updated.

@slava77
Copy link

slava77 commented Dec 18, 2023

@rappoccio
this is required with cms-sw/cmssw#43580 (which was merged)

@smuzaffar
Copy link
Contributor

+externals

This has been tested via cms-sw/cmssw#43580

@smuzaffar
Copy link
Contributor

@rappoccio , as cms-sw/cmssw#43580 has been merged so I am merging this one too otherwise we might have broken IBs

@smuzaffar smuzaffar merged commit d699c98 into cms-data:main Dec 18, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants