Install a SIGTERM handler in addition to SIGINT #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows cleanly terminating CMS by sending it SIGTERM, which is what e.g. Docker or systemd do.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1246 +/- ##
==========================================
- Coverage 69.45% 69.45% -0.01%
==========================================
Files 328 328
Lines 26196 26201 +5
==========================================
+ Hits 18195 18198 +3
- Misses 8001 8003 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows cleanly terminating CMS by sending it SIGTERM, which is what e.g. Docker or systemd do.
I ran into this while using docker-compose, which when asked to stop a container will send it SIGTERM, then wait 10 seconds, and then send SIGKILL. I think terminating CMS via SIGKILL isn't particuarly nice (and also I don't like waiting 10 seconds every time I want to restart a container).