Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements #60

Merged
merged 8 commits into from
May 6, 2018
Merged

Conversation

kpedro88
Copy link

@kpedro88 kpedro88 commented May 4, 2018

Following up on list of suggestions in #59.

A few specific notes:

  • verbosity levels are: 0 = no printouts, 1 = warnings only, 2 = warnings & info, 3 = warnings, info, debug
    (2 is the default)
  • using print() as a function instead of a statement will help with eventual python3 transition
  • also ported the separate subjetBTagDiscriminator list from Adding some tools and fixing bugs for next version #47

DeepFlavour support still needs to be added, but I'm not sure what that entails.

@alefisico alefisico merged commit 17b81fa into cms-jet:jetToolbox_94X May 6, 2018
@alefisico
Copy link
Member

Hi @kpedro88 sorry for the late reply about this, but I am a bit confused with the associatedTask option. If this is false, then I would need to include a process.endpath = cms.EndPath() in my other python cfg file or what exactly I need to include? Thanks!

@kpedro88
Copy link
Author

@alefisico with associateTask=False, you need to associate the jetTask to a cms.Path() or cms.EndPath().

In TreeMaker, I do the following (to avoid worrying about jetTask separately from my other producers):
https://github.com/TreeMaker/TreeMaker/blob/27958323802b39b1da622a7da53e8baf4e50069a/TreeMaker/python/makeTreeFromMiniAOD_cff.py#L905-L914

@alefisico
Copy link
Member

ok that was my confusion, you do not only need to associate the jetTask to cms.Path() but also include the module which uses the output collections of the JetToolbox to the path, like in your line 912.
I got a question about this and it took me a while to understand this.
Thanks, I think I need to add this information in the twiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants