Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing inputs for DeepDoubleX and DeepAK8 #12

Open
jmduarte opened this issue May 24, 2020 · 7 comments
Open

Missing inputs for DeepDoubleX and DeepAK8 #12

jmduarte opened this issue May 24, 2020 · 7 comments

Comments

@jmduarte
Copy link
Contributor

jmduarte commented May 24, 2020

In general, I'm interested in using this format as a standard for training/re-training deep jet taggers. So it'd be nice to have a complete set of inputs (enabled with some flag).

I can try to help add these in a pull request, although I think I'll need some guidance. In particular, how can we add variables to the jet table?

@andrzejnovak

@andrzejnovak
Copy link
Collaborator

I think for the "jet-level" variables there would have to be a new module, similar to the JetConstituents table.

Adding additional per particle inputs should be more straightforward, I think it would just require replicating some of this logic somewhere around here.

@rappoccio
Copy link
Member

We can probably do all of it within the JetConstituentTableProducer, no?

@nsmith-
Copy link
Contributor

nsmith- commented Jun 2, 2020

For jet-level ones I think I got a solution in master...DAZSLE:DeepDoubleX
Javier is going to fill in the details (since I'm not so familiar with the variables)

@alefisico
Copy link
Member

Just merged #14
Is there something else missing?

@andrzejnovak
Copy link
Collaborator

andrzejnovak commented Jun 3, 2020 via email

@alefisico
Copy link
Member

Yeah the pf cand related info

On Wed, Jun 3, 2020, 10:05 Alejandro Gomez Espinosa < @.***> wrote: Just merged #14 <#14> Is there something else missing? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADE5EBBX4OWXSQW3HPQ2TTDRUX76JANCNFSM4NIXGGBA .

is there something still missing here?

@andrzejnovak
Copy link
Collaborator

I browsed through this yesterday, all the per jet and SV information is in. It's a bit trickier with the PF cands. Ideally, we'd be able to get the info from the FeatureProducers for the taggers themselves, but I didn't figure it out yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants