-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconfigure interface for saving PF cands #31
base: master
Are you sure you want to change the base?
Conversation
I forgot to say, I also added some commented-out lines to add AK15 PF candidates as placeholders, but the AK15 jets don't actually exist anywhere yet. |
Just to make sure I understand, the PR adds everything for ak15 jets to be included but does not include them yet? Is this correct? |
Hi @alefisico - the commented AK15 lines are just copies of the AK8 lines, so I think they're everything needed to add AK15 PF candidates, once the AK15 jets themselves are added. I'm still working on adding the AK15 jets themselves, so the AK15 PF candidate code is not validated at all. Maybe I should remove them for now, and put them back once they're tested? |
Ah, yeah maybe, to avoid confusion. The other idea would be to leave this PR open until the AK15 jets are included and then we merge it. No strong opinion. |
1 similar comment
Ah, yeah maybe, to avoid confusion. The other idea would be to leave this PR open until the AK15 jets are included and then we merge it. No strong opinion. |
OK, I have removed the AK15 template code. Can go back to 22b8fc0 if a reference is needed. |
Hey @DryRun is this PR ready? I try to run it and I am getting errors like this:
when running |
Hi @alefisico (and @andrzejnovak) - sorry, not yet. Two problems:
|
Ah no problem, I was just wondering if you want me to merge it or not. Just let me know. |
(I'm not sure this is the best place to talk about AK15 in general, maybe we should discuss this first)
Before trying to add AK15 PF candidates, this PR changes the arguments for
addPFcands()
andadd_BTV()
to specify which collections to save inclusively (addAK4
,addAK8
) instead of exclusively (onlyAK4
,onlyAK8
). This makes it easier to add another collection (addAK15
), instead of enumerating the 2^(N jet collections) combinations.Validation
Recreated all the CMSSW config files with
make_configs_UL.sh
, dumped the full configs withedmConfigDump
, and confirmed that the configs are identical withdiff
, except for an intended change to the docstring ("from AK4 and AK8 jets" --> "from various jet collections").