New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in large pileup weight handling #197

Merged

fgolf merged 1 commit into cms-nanoAOD:master from AndrewLevin:bugfix_puweightproducer

Oct 17, 2019

Contributor

AndrewLevin commented Oct 16, 2019

Currently, the cropped vector will grow larger and larger in each iteration, while it should always have a fixed length or be empty.


bugfix: cropped vector should be cleared in each iteration

8ade524

AndrewLevin mentioned this pull request

Correctly recompute PU weights in case of an upper bound #87

Open

Contributor

fgolf commented Oct 17, 2019

Accepting this PR to fix the nan problem and we'll follow-up on proposed changes in PR #87 .

fgolf merged commit ccb9bfd into cms-nanoAOD:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment