Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify cudacompat layer to use a 1-dimensional grid #586

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Simplify cudacompat layer to use a 1-dimensional grid #586

merged 3 commits into from
Dec 1, 2020

Commits on Nov 30, 2020

  1. Simplify cudacompat layer to use a 1-dimensional grid 

    Remove the possibility of changing the grid size used by the
cms::cudacompat layer, and make it a constant equal to {1, 1, 1}.

This avoids a thread-related problem caused by TBB using worker threads
where the grid size had not been initialised.

The kernel for pixel clustering need to be rewritten to support a
one-dimensional grid to run on the CPU.
Currently they are only used on the GPU in the Patatrack workflows, but
they are exercised on the CPU by the gpuClustering_t tests; those tests
have been commented out until the kernels can be updated.
    @fwyzard
    fwyzard committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    9a6fe7d View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary asserts

    @fwyzard
    fwyzard authored Nov 30, 2020
    Configuration menu
    Copy the full SHA
    e32c4ed View commit details
    Browse the repository at this point in the history

  3. Fix typo in the comment 

    Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>
    @fwyzard @makortel
    fwyzard and makortel authored Nov 30, 2020
    Configuration menu
    Copy the full SHA
    40220bd View commit details
    Browse the repository at this point in the history