Automatically merge cmsdist PR that updates cmsswdata if correspondin… #2169
Conversation
…g cms-data PR was for the default branch
|
A new Pull Request was created by @iarspider for branch master. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
| @@ -203,3 +203,7 @@ def get_tag_from_string(tag_string=None): | |||
| change_tag_pull_request = dist_repo.create_pull( | |||
| title=title, body=body, base=default_cms_dist_branch, head=repo_tag_pr_branch | |||
| ) | |||
|
|
|||
| if data_pr_base_branch == data_repo_default_branch: | |||
| print("cms-data PR was for default branch, will merge now") | |||
There was a problem hiding this comment.
@iarspider , may be add a comment to PR that why it is automatically merged.
Also I would suggest to a add a new command-line option e.g. --no-merge (default value False) so we can use it (if needed) to only create the PR without merge
|
Pull request #2169 was updated. |
|
Pull request #2169 was updated. |
|
Pull request #2169 was updated. |
|
+externals tested via creating test PR iarspider/cmsdist#1 |
cmsbuild
added
fully-signed
externals-approved
and removed
pending-signatures
externals-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
…g cms-data PR was for the default branch