Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid processing toolnames with same name but different capitalization #2194

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Mar 12, 2024

While testing cms-sw/cmsdist#9042, I noticed that PR tests script assumes that some tools were removed and tries to rebuild nealy full cmssw during PR tests. This is because some toolfiles have different capitalization but they point to same tool/package (e.g OpenBlas and openblas). This change should avoid such cases for CMSSW releases with SCRAM V2

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#9042

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch master.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #2194 was updated.

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#9066

@cmsbuild
Copy link
Contributor

Pull request #2194 was updated.

@smuzaffar
Copy link
Contributor Author

+externals

PR tests looks good for cms-sw/cmsdist#9042 (for 10.6.X wiyh SCRAMV2) and cms-sw/cmsdist#9066 (for 14.1.X with SCRAM V3)

@smuzaffar smuzaffar merged commit 140cebd into master Mar 12, 2024
3 of 5 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the pr-test-tool-name-capitalization branch April 25, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants