Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "ngt" label #2396

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Add "ngt" label #2396

merged 1 commit into from
Dec 9, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Dec 8, 2024

Add the ngt label, to support the type ngt bot command.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2024

A new Pull Request was created by @fwyzard for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2024

Pull request #2396 was updated.

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 8, 2024

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 8, 2024

type ngt

(I'm just curious to see what happens)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ffbb0/43317/summary.html
COMMIT: dd77767
CMSSW: CMSSW_15_0_X_2024-12-08-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2396/43317/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3510017
  • DQMHistoTests: Total failures: 375
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3509622
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@fwyzard , what is ngt ?
If it is only used for adding ngt label by explicitly using type ngt comment then please include it in https://github.com/cms-sw/cms-bot/blob/master/githublabels.py#L32 . If we want bot to automatically set this label based on changes set then it should go in https://github.com/cms-sw/cms-bot/blob/master/categories_map.py#L1801

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 9, 2024

what is ngt ?

the NextGen Trigger project, that is developing additional L1T and HLT functionalities for Phase 2.

The idea is to be able to quickly point out which developments come from this project, since we have to give yearly reports on the developments to the foundations that funds the project.

If it is only used for adding ngt label by explicitly using type ngt comment then please include it in https://github.com/cms-sw/cms-bot/blob/master/githublabels.py#L32

Yes, that was the idea.
I'll make the changes, thanks for the correction.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2024

Pull request #2396 was updated.

githublabels.py Show resolved Hide resolved
@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 9, 2024

please test

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar smuzaffar merged commit e50e907 into cms-sw:master Dec 9, 2024
9 of 10 checks passed
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild cmsbuild added the ngt label Dec 9, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ffbb0/43331/summary.html
COMMIT: 40cfeb2
CMSSW: CMSSW_15_0_X_2024-12-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2396/43331/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3510017
  • DQMHistoTests: Total failures: 681
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3509316
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants