Skip to content

Commit

Permalink
build vecgeom with default flags i.e. drop explicit -O2 for gcc11 and…
Browse files Browse the repository at this point in the history 
… above
  • Loading branch information
@smuzaffar
smuzaffar committed Aug 17, 2022
1 parent fd4ea86 commit d8000cf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion vecgeom.spec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ cmake ../%{n}-%{realversion} \
-DCMAKE_AR=$(which gcc-ar) \
-DCMAKE_RANLIB=$(which gcc-ranlib) \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_CXX_FLAGS_RELEASE="-O2 -DNDEBUG" \
-DCMAKE_CXX_FLAGS_RELEASE="-DNDEBUG" \
-DNO_SPECIALIZATION=ON \
-DBACKEND=Scalar \
%ifarch x86_64
Expand Down

2 comments on commit d8000cf

@hahnjo
Copy link
Contributor

@hahnjo hahnjo commented on d8000cf Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @smuzaffar, I think this will not work as intended and now build VecGeom without any -O flags, so -O0. If you want to go back to the default, you should remove the setting of CMAKE_CXX_FLAGS_RELEASE.

@smuzaffar
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok ok, thanks for checking

Please sign in to comment.