Add mkfit to cmssw-tool-conf

[makortel]

Apparently #5150 was not sufficient, but mkfit-toolfile needs to be added to cmssw-tool-conf. Is anything else needed to get the external usable from CMSSW?

@slava77

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for branch IB/CMSSW_11_0_X/gcc700.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2187/console Started: 2019/08/26 17:47

[cmsbuild]

+1
Tested at: aa42ff6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47ccd8/2187/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47ccd8/2187/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2939508
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2939166
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[smuzaffar]

@makortel , every new external needs to go in to cmssw-tool-conf in order to get it in the distribution.
By the way, I see that there is $MKFIT_BASE/Geoms directory with these two lib/plugins CMS-2017.so, CylCowWLids.so. Do we need this path be in LIBDIR or not?

[makortel]

every new external needs to go in to cmssw-tool-conf in order to get it in the distribution.

Right, thanks, I just didn't realize that until now.

By the way, I see that there is $MKFIT_BASE/Geoms directory with these two lib/plugins CMS-2017.so, CylCowWLids.so. Do we need this path be in LIBDIR or not?

They are not needed in LIBDIR, because one of those .so's is explicitly loaded with dlopen() by the mkfit external .

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[mrodozov]

@makortel any suggestion on what to hack since it doesn't build on arm ? I'm expecting the same story for ppc. I'll put it in arch condition for now