MkFit - add in architecture condition #5174

mrodozov · 2019-08-27T12:56:08Z

The external doesn't build for arm, expecting the same for ppc, put it in conditional statement until we have a proper fix

cmsbuild · 2019-08-27T12:56:41Z

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_0_X/gcc700.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

mrodozov · 2019-08-27T12:56:54Z

please test

cmsbuild · 2019-08-27T12:57:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2219/console Started: 2019/08/27 14:58

slava77 · 2019-08-27T13:03:43Z

@mrodozov
in case the mkFit developers can make it work on these archs: which nodes can be used for testing?

@makortel
@osschar

makortel · 2019-08-27T14:43:12Z

@mrodozov Thanks. Would you happen to have pointers to the build logs on arm (and power) to get a glimpse on the failures? Eventually, as @slava77 wrote, they would need to be addressed by the developers.

I suppose the (upcoming) CMSSW lib and plugin need a similar arch protection as well, right? (as otherwise they couldn't link mkfit external)

cmsbuild · 2019-08-27T14:59:46Z

+1
Tested at: 7064c34
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-908dbc/2219/summary.html

cmsbuild · 2019-08-27T14:59:50Z

Comparison job queued.

cmsbuild · 2019-08-27T16:59:51Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-908dbc/2219/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2939508
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2939166
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 145 log files, 15 edm output root files, 34 DQM output files

cmsbuild · 2019-08-27T21:22:49Z

Pull request #5174 was updated.

mrodozov · 2019-08-27T21:24:38Z

please test
this "fixes" arm in terms of "it compiles", for ppc we need a bit more

cmsbuild · 2019-08-27T21:25:03Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2227/console Started: 2019/08/27 23:25

mrodozov · 2019-08-28T10:20:18Z

please test for slc7_ppc64le_gcc700

cmsbuild · 2019-08-28T10:20:45Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2230/console Started: 2019/08/28 12:23

cmsbuild · 2019-08-28T11:38:18Z

-1

Tested at: 8113f86

Build:

I found compilation error when building:

g++ -MM -MG -MQ 'Config.o' -I. -DUSE_MATRIPLEX -DMPLEX_USE_INTRINSICS -DCHECKSTATEVALID      -I/build/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/slc7_ppc64le_gcc700/external/tbb/2019_U8/include -DTBB -DNO_ROOT -std=c++14  -o Config.d Config.cc
g++ -MM -MG -MQ 'Simulation.o' -I. -DUSE_MATRIPLEX -DMPLEX_USE_INTRINSICS -DCHECKSTATEVALID      -I/build/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/slc7_ppc64le_gcc700/external/tbb/2019_U8/include -DTBB -DNO_ROOT -std=c++14  -o Simulation.d Simulation.cc
g++ -MM -MG -MQ 'Hit.o' -I. -DUSE_MATRIPLEX -DMPLEX_USE_INTRINSICS -DCHECKSTATEVALID      -I/build/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/slc7_ppc64le_gcc700/external/tbb/2019_U8/include -DTBB -DNO_ROOT -std=c++14  -o Hit.d Hit.cc
g++ -MM -MG -MQ 'Validation.o' -I. -DUSE_MATRIPLEX -DMPLEX_USE_INTRINSICS -DCHECKSTATEVALID      -I/build/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/slc7_ppc64le_gcc700/external/tbb/2019_U8/include -DTBB -DNO_ROOT -std=c++14  -o Validation.d Validation.cc
g++ -I. -DUSE_MATRIPLEX -DMPLEX_USE_INTRINSICS -DCHECKSTATEVALID      -I/build/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/slc7_ppc64le_gcc700/external/tbb/2019_U8/include -DTBB -DNO_ROOT -std=c++14  -fPIC -g -O3  -std=c++1z -ftree-vectorize -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -Wstrict-overflow -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Wstrict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -fdiagnostics-color=always -fdiagnostics-show-option -pthread -pipe -fopenmp  -march=native -c -o Validation.o Validation.cc
�[01m�[Kg++:�[m�[K �[01;31m�[Kerror: �[m�[Kunrecognized command line option '�[01m�[K-march=native�[m�[K'; did you mean '�[01m�[K-mcpu=native�[m�[K'?
make: *** [Validation.o] Error 1
error: Bad exit status from /build/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.pzXFeG (%build)


RPM build errors:

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-908dbc/2230/summary.html

smuzaffar · 2019-08-28T11:56:06Z

please test for slc7_ppc64le_gcc700

cmsbuild · 2019-08-28T11:56:10Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2233/console Started: 2019/08/28 13:59

cmsbuild · 2019-08-28T11:56:11Z

Pull request #5174 was updated.

davidlange6 · 2019-08-28T12:08:15Z

nothing to do with the build error - but should this not be compiled with some optimization?

…

On Aug 28, 2019, at 1:38 PM, cmsbuild ***@***.***> wrote: -1 Tested at: 8113f86 • Build: I found compilation error when building: g++ -MM -MG -MQ 'Config.o' -I. -DUSE_MATRIPLEX -DMPLEX_USE_INTRINSICS -DCHECKSTATEVALID -I/build/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/slc7_ppc64le_gcc700/external/tbb/2019_U8/include -DTBB -DNO_ROOT -std=c++14 -o Config.d Config.cc g++ -MM -MG -MQ 'Simulation.o' -I. -DUSE_MATRIPLEX -DMPLEX_USE_INTRINSICS -DCHECKSTATEVALID -I/build/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/slc7_ppc64le_gcc700/external/tbb/2019_U8/include -DTBB -DNO_ROOT -std=c++14 -o Simulation.d Simulation.cc g++ -MM -MG -MQ 'Hit.o' -I. -DUSE_MATRIPLEX -DMPLEX_USE_INTRINSICS -DCHECKSTATEVALID -I/build/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/slc7_ppc64le_gcc700/external/tbb/2019_U8/include -DTBB -DNO_ROOT -std=c++14 -o Hit.d Hit.cc g++ -MM -MG -MQ 'Validation.o' -I. -DUSE_MATRIPLEX -DMPLEX_USE_INTRINSICS -DCHECKSTATEVALID -I/build/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/slc7_ppc64le_gcc700/external/tbb/2019_U8/include -DTBB -DNO_ROOT -std=c++14 -o Validation.d Validation.cc g++ -I. -DUSE_MATRIPLEX -DMPLEX_USE_INTRINSICS -DCHECKSTATEVALID -I/build/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/slc7_ppc64le_gcc700/external/tbb/2019_U8/include -DTBB -DNO_ROOT -std=c++14 -fPIC -g -O3 -std=c++1z -ftree-vectorize -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -Wstrict-overflow -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Wstrict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -fdiagnostics-color=always -fdiagnostics-show-option -pthread -pipe -fopenmp -march=native -c -o Validation.o Validation.cc �[01m�[Kg++:�[m�[K �[01;31m�[Kerror: �[m�[Kunrecognized command line option '�[01m�[K-march=native�[m�[K'; did you mean '�[01m�[K-mcpu=native�[m�[K'? make: *** [Validation.o] Error 1 error: Bad exit status from /build/cmsbld/jenkins_a/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.pzXFeG (%build) RPM build errors: You can see the results of the tests here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-908dbc/2230/summary.html — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

mrodozov · 2019-08-28T15:37:23Z

update to use single patch is here https://github.com/mrodozov/cmsdist/tree/adjusting_mkfit
I'll push it when the ppc tests are finished (not to ruin the relval results, the test is at the end)
@davidlange6 I'd left it to the devs first to propose suggestions

cmsbuild · 2019-08-28T19:22:00Z

-1

Tested at: dff60c2

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-908dbc/2233/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

The relvals timed out after 4 hours.

cmsbuild · 2019-08-28T19:22:14Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

smuzaffar · 2019-08-28T21:00:32Z

closing in favor of #5179 which uses a simple patch.

smuzaffar · 2019-08-29T14:09:40Z

@davidlange6 , about optimization option. It does build with -O3 . The g++ -MM -MG -MQ ... commands without any optimization options are for generating Make dependencies .

MkFit - add in architecture condition

7064c34

The external doesn't build for arm, expecting the same for ppc, put it in conditional statement until we have a proper fix

cmsbuild added comparison-pending externals-pending orp-pending pending-signatures tests-pending labels Aug 27, 2019

cmsbuild added tests-started and removed tests-pending labels Aug 27, 2019

cmsbuild added tests-approved and removed tests-started labels Aug 27, 2019

cmsbuild added comparison-available and removed comparison-pending labels Aug 27, 2019

Put a fix for arm , ppc still have troubles problems

a2ae24f

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Aug 27, 2019

cmsbuild added tests-started and removed tests-pending labels Aug 27, 2019

cmsbuild added tests-started and removed tests-pending labels Aug 28, 2019

mrodozov mentioned this pull request Aug 28, 2019

Put conditions for headers depending on the architecture trackreco/mkFit#240

Open

cmsbuild added tests-rejected and removed tests-started labels Aug 28, 2019

slava77 mentioned this pull request Aug 28, 2019

Integration to CMSSW master trackreco/mkFit#236

Closed

18 tasks

Update mkfit.spec

dff60c2

cmsbuild added tests-pending and removed tests-rejected labels Aug 28, 2019

cmsbuild added tests-started and removed tests-pending labels Aug 28, 2019

makortel mentioned this pull request Aug 28, 2019

Add EDProducers for mkFit cms-sw/cmssw#27895

Merged

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Aug 28, 2019

smuzaffar closed this Aug 28, 2019

smuzaffar deleted the put-mkfit-in-arch-condition branch September 6, 2019 15:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MkFit - add in architecture condition #5174

MkFit - add in architecture condition #5174

mrodozov commented Aug 27, 2019

cmsbuild commented Aug 27, 2019

mrodozov commented Aug 27, 2019

cmsbuild commented Aug 27, 2019 •

edited

Loading

slava77 commented Aug 27, 2019

makortel commented Aug 27, 2019

cmsbuild commented Aug 27, 2019

cmsbuild commented Aug 27, 2019

cmsbuild commented Aug 27, 2019

cmsbuild commented Aug 27, 2019

mrodozov commented Aug 27, 2019

cmsbuild commented Aug 27, 2019 •

edited

Loading

mrodozov commented Aug 28, 2019

cmsbuild commented Aug 28, 2019 •

edited

Loading

cmsbuild commented Aug 28, 2019

smuzaffar commented Aug 28, 2019

cmsbuild commented Aug 28, 2019 •

edited

Loading

cmsbuild commented Aug 28, 2019

davidlange6 commented Aug 28, 2019 via email

mrodozov commented Aug 28, 2019

cmsbuild commented Aug 28, 2019

cmsbuild commented Aug 28, 2019

smuzaffar commented Aug 28, 2019

smuzaffar commented Aug 29, 2019

MkFit - add in architecture condition #5174

MkFit - add in architecture condition #5174

Conversation

mrodozov commented Aug 27, 2019

cmsbuild commented Aug 27, 2019

mrodozov commented Aug 27, 2019

cmsbuild commented Aug 27, 2019 • edited Loading

slava77 commented Aug 27, 2019

makortel commented Aug 27, 2019

cmsbuild commented Aug 27, 2019

cmsbuild commented Aug 27, 2019

cmsbuild commented Aug 27, 2019

cmsbuild commented Aug 27, 2019

mrodozov commented Aug 27, 2019

cmsbuild commented Aug 27, 2019 • edited Loading

mrodozov commented Aug 28, 2019

cmsbuild commented Aug 28, 2019 • edited Loading

cmsbuild commented Aug 28, 2019

smuzaffar commented Aug 28, 2019

cmsbuild commented Aug 28, 2019 • edited Loading

cmsbuild commented Aug 28, 2019

davidlange6 commented Aug 28, 2019 via email

mrodozov commented Aug 28, 2019

cmsbuild commented Aug 28, 2019

cmsbuild commented Aug 28, 2019

smuzaffar commented Aug 28, 2019

smuzaffar commented Aug 29, 2019

cmsbuild commented Aug 27, 2019 •

edited

Loading

cmsbuild commented Aug 27, 2019 •

edited

Loading

cmsbuild commented Aug 28, 2019 •

edited

Loading

cmsbuild commented Aug 28, 2019 •

edited

Loading