update sigcpp from 2.6.2 to 3.0.7 #7441

ddaina · 2021-11-10T08:08:42Z

resolves #7440

cmsbuild · 2021-11-10T08:09:01Z

A new Pull Request was created by @ddaina (Daina) for branch IB/CMSSW_12_2_X/master.

@cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

smuzaffar · 2021-11-10T08:16:18Z

thanks @ddaina , can you please use the sources from https://github.com/libsigcplusplus/libsigcplusplus/archive/refs/tags/%{realversion}.tar.gz and update https://github.com/cms-sw/cmsdist/pull/7441/files#diff-a74d26461bdcbb7dcdd15733528160d42c03aee4744b56b24d6e6e92546e0303R8 is needed?

cmsbuild · 2021-11-10T08:39:29Z

Pull request #7441 was updated.

smuzaffar · 2021-11-10T08:43:59Z

@ddaina , please check if https://github.com/cms-sw/cmsdist/pull/7441/files#diff-a74d26461bdcbb7dcdd15733528160d42c03aee4744b56b24d6e6e92546e0303L26 is correct? with sigccp version 3 we might have to fix this too? I would suggest to try to build locally first.

smuzaffar · 2021-11-10T22:12:22Z

please test

cmsbuild · 2021-11-10T23:03:09Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38d931/20443/summary.html
COMMIT: 74db3ad
CMSSW: CMSSW_12_2_X_2021-11-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7441/20443/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

+ tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd libsigc++-3.0.7
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.5dvN6G: line 39: cd: libsigc++-3.0.7: No such file or directory
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.5dvN6G (%prep)


RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.5dvN6G (%prep)

cmsbuild · 2021-11-11T08:40:49Z

Pull request #7441 was updated.

sigcpp.spec

cmsbuild · 2021-11-11T09:26:39Z

Pull request #7441 was updated.

smuzaffar · 2021-11-11T09:37:29Z

please test

cmsbuild · 2021-11-11T10:10:22Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38d931/20457/summary.html
COMMIT: 59e422e
CMSSW: CMSSW_12_2_X_2021-11-10-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7441/20457/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38d931/20457/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38d931/20457/git-merge-result

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-11-10-2300/src/Fireworks/Core/src/CmsShowModelPopup.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-11-10-2300/src/Fireworks/Core/src/CmsShowMainFrame.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-11-10-2300/src/Fireworks/Core/src/CmsShowNavigator.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-11-10-2300/src/Fireworks/Core/src/CmsShowSearchFiles.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-11-10-2300/src/Fireworks/Core/src/CSGActionSupervisor.cc:15:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-11-10-2300/src/Fireworks/Core/interface/CSGAction.h:100:22: error: field 'activated' has incomplete type 'sigc::signal'
  100 |   sigc::signal activated;
      |                      ^~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/sigcpp/3.0.7-78c11f8d5ed5c9324bb249a7b162f74c/include/sigc++-3.0/sigc++/sigc++.h:118,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_2_X_2021-11-10-2300/src/Fireworks/Core/src/CSGActionSupervisor.cc:12:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/external/sigcpp/3.0.7-78c11f8d5ed5c9324bb249a7b162f74c/include/sigc++-3.0/sigc++/signal.h:533:7: note: declaration of 'class sigc::signal'

cmsbuild · 2021-12-03T19:28:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38d931/20961/summary.html
COMMIT: 59e422e
CMSSW: CMSSW_12_2_X_2021-12-01-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7441/20961/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38d931/20961/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38d931/20961/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 31012 differences found in the comparisons
DQMHistoTests: Total files compared: 41
DQMHistoTests: Total histograms compared: 3041955
DQMHistoTests: Total failures: 174287
DQMHistoTests: Total nulls: 2
DQMHistoTests: Total successes: 2867644
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
Checked 175 log files, 37 edm output root files, 41 DQM output files
TriggerResults: no differences found

smuzaffar · 2021-12-07T08:19:05Z

unhold

smuzaffar · 2021-12-07T08:20:08Z

please test

cmsbuild · 2021-12-07T17:37:02Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38d931/21042/summary.html
COMMIT: 59e422e
CMSSW: CMSSW_12_3_X_2021-12-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7441/21042/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38d931/21042/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38d931/21042/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 3250608
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3250586
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

smuzaffar · 2021-12-10T20:39:12Z

please test

smuzaffar · 2021-12-10T20:40:04Z

+externals

cmsbuild · 2021-12-10T20:40:07Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_3_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2021-12-11T00:26:27Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38d931/21186/summary.html
COMMIT: 59e422e
CMSSW: CMSSW_12_3_X_2021-12-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7441/21186/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38d931/21186/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38d931/21186/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 3250704
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3250676
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

perrotta · 2021-12-13T18:21:06Z

+1

It needs Transition from sigcpp-2 to sigcpp-3 cmssw#36343

update sigcpp from 2.6.2 to 3.0.7

b82b2ba

cmsbuild added the externals-pending label Nov 10, 2021

cmsbuild added orp-pending pending-signatures tests-pending labels Nov 10, 2021

use correct source

74db3ad

cmsbuild added tests-started and removed tests-pending labels Nov 10, 2021

cmsbuild added tests-rejected and removed tests-started labels Nov 10, 2021

update sigcpp from 2.6.2 to 3.0.7 - v2

e753fc5

cmsbuild added tests-pending and removed tests-rejected labels Nov 11, 2021

smuzaffar reviewed Nov 11, 2021

View reviewed changes

sigcpp.spec Outdated Show resolved Hide resolved

add gmake dependency

59e422e

cmsbuild added tests-started and removed tests-pending labels Nov 11, 2021

cmsbuild added tests-rejected and removed tests-started labels Nov 11, 2021

smuzaffar mentioned this pull request Nov 11, 2021

[ASAN] new-delete-type-mismatch in FWModelChangeManager::newItemSlot cms-sw/cmssw#36056

Open

smuzaffar changed the base branch from IB/CMSSW_12_2_X/master to IB/CMSSW_12_3_X/master December 6, 2021 21:30

cmsbuild removed the hold label Dec 7, 2021

cmsbuild added tests-started and removed tests-approved labels Dec 7, 2021

cmsbuild added tests-approved and removed tests-started labels Dec 7, 2021

cmsbuild added tests-started and removed tests-approved labels Dec 10, 2021

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Dec 10, 2021

cmsbuild added tests-approved and removed tests-started labels Dec 11, 2021

cmsbuild added orp-approved and removed orp-pending labels Dec 13, 2021

cmsbuild merged commit 0ca0430 into cms-sw:IB/CMSSW_12_3_X/master Dec 13, 2021

This was referenced Dec 14, 2021

[ROOT62.4] Update root to latest v6.24 changes #7507

Merged

external lib for HYDJET++ #7483

Merged

Hydjet++ 2.4.3 integration cms-sw/cmssw#36316

Merged

perrotta mentioned this pull request Dec 14, 2021

modernize MuonAnalysis/MomentumScaleCalibration cms-sw/cmssw#36485

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update sigcpp from 2.6.2 to 3.0.7 #7441

update sigcpp from 2.6.2 to 3.0.7 #7441

ddaina commented Nov 10, 2021

cmsbuild commented Nov 10, 2021

smuzaffar commented Nov 10, 2021

cmsbuild commented Nov 10, 2021

smuzaffar commented Nov 10, 2021

smuzaffar commented Nov 10, 2021

cmsbuild commented Nov 10, 2021

cmsbuild commented Nov 11, 2021

cmsbuild commented Nov 11, 2021

smuzaffar commented Nov 11, 2021

cmsbuild commented Nov 11, 2021

cmsbuild commented Dec 3, 2021

smuzaffar commented Dec 7, 2021

smuzaffar commented Dec 7, 2021

cmsbuild commented Dec 7, 2021

smuzaffar commented Dec 10, 2021

smuzaffar commented Dec 10, 2021

cmsbuild commented Dec 10, 2021

cmsbuild commented Dec 11, 2021

perrotta commented Dec 13, 2021

update sigcpp from 2.6.2 to 3.0.7 #7441

update sigcpp from 2.6.2 to 3.0.7 #7441

Conversation

ddaina commented Nov 10, 2021

cmsbuild commented Nov 10, 2021

smuzaffar commented Nov 10, 2021

cmsbuild commented Nov 10, 2021

smuzaffar commented Nov 10, 2021

smuzaffar commented Nov 10, 2021

cmsbuild commented Nov 10, 2021

External Build

cmsbuild commented Nov 11, 2021

cmsbuild commented Nov 11, 2021

smuzaffar commented Nov 11, 2021

cmsbuild commented Nov 11, 2021

Build

cmsbuild commented Dec 3, 2021

Comparison Summary

smuzaffar commented Dec 7, 2021

smuzaffar commented Dec 7, 2021

cmsbuild commented Dec 7, 2021

Comparison Summary

smuzaffar commented Dec 10, 2021

smuzaffar commented Dec 10, 2021

cmsbuild commented Dec 10, 2021

cmsbuild commented Dec 11, 2021

Comparison Summary

perrotta commented Dec 13, 2021