Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAB: update crab-prod to v3.211130 #7484

Merged
merged 1 commit into from
Dec 1, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crab-build.file
Original file line number Diff line number Diff line change
@@ -40,7 +40,7 @@ echo dbs >> %{i}/etc/crab_py_pkgs.txt
echo RestClient >> %{i}/etc/crab_py_pkgs.txt

#Copy WMCore
if [ "%{crab_type}" != "dev" ] ; then
if [ "%{crab_type}" == "pre" ] ; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddaina , is this what you want? pre will use WMCore and prod and dev will use CRABClient/WMCoreConfiguration.py ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's what we want. We use pre as previous so users can fall back to it in case of problems when we move from dev to prod. We do not have means to do a menaingful validation in "preprod" after we do our best in dev which in this case includes having CMSSW_12 users use it !

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, I thought pre stands for for pre-production/pre-release :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no reason to feel bad. It was a dirty expedient I dreamed off. And not standard in any way. Yes, it is a devious use of the pre prefix , sorry about that. Did not want to ask you to introduce a crab-old

for pkg in %{wmcore_packages} ; do
if [ -d %{_builddir}/WMCore/src/python/${pkg} ] ; then
rsync -a %{_builddir}/WMCore/src/python/${pkg} %{i}/lib/
2 changes: 1 addition & 1 deletion crab-dev.spec
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
#For new crabclient_version, set the version_suffix to 00
#For any other change, increment version_suffix
##########################################
%define version_suffix 00
%define version_suffix 01
%define crabclient_version v3.211130
### RPM cms crab-dev %{crabclient_version}.%{version_suffix}
%define wmcore_version 1.5.3
2 changes: 1 addition & 1 deletion crab-pre.spec
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
#For new crabclient_version, set the version_suffix to 00
#For any other change, increment version_suffix
##########################################
%define version_suffix 03
%define version_suffix 04
%define crabclient_version v3.210825
### RPM cms crab-pre %{crabclient_version}.%{version_suffix}
%define wmcore_version 1.3.6.crab6
8 changes: 4 additions & 4 deletions crab-prod.spec
Original file line number Diff line number Diff line change
@@ -2,11 +2,11 @@
#For new crabclient_version, set the version_suffix to 00
#For any other change, increment version_suffix
##########################################
%define version_suffix 05
%define crabclient_version v3.210825
%define version_suffix 00
%define crabclient_version v3.211130
### RPM cms crab-prod %{crabclient_version}.%{version_suffix}
%define wmcore_version 1.3.6.crab6
%define crabserver_version v3.210611p1
%define wmcore_version 1.5.3
%define crabserver_version v3.211025
%define dbs_version 3.14.0

## IMPORT crab-build