Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: libzmq #7550

Merged
merged 8 commits into from
Jan 23, 2022
Merged

New package: libzmq #7550

merged 8 commits into from
Jan 23, 2022

Conversation

iarspider
Copy link
Contributor

@iarspider iarspider commented Jan 17, 2022

This is needed for py3-pyzmq.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_12_3_X/master.

@smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@iarspider iarspider requested review from smuzaffar and removed request for smuzaffar January 17, 2022 12:59
@iarspider iarspider changed the title New package: libzmq [WIP] New package: libzmq Jan 17, 2022
@cmsbuild
Copy link
Contributor

Pull request #7550 was updated.

@cmsbuild
Copy link
Contributor

Pull request #7550 was updated.

@cmsbuild
Copy link
Contributor

Pull request #7550 was updated.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e64a53/21756/summary.html
COMMIT: 32f957a
CMSSW: CMSSW_12_3_X_2022-01-16-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7550/21756/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3464734
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3464712
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@iarspider have you checked building it locally that the libzmq is found at runtime?

@iarspider
Copy link
Contributor Author

@smuzaffar py3-pyzmq correctly picks up our version of libzmq, and (after setting the environment) examples from pyzmq github work fine.

@iarspider iarspider changed the title [WIP] New package: libzmq New package: libzmq Jan 18, 2022
@cmsbuild
Copy link
Contributor

Pull request #7550 was updated.

@iarspider
Copy link
Contributor Author

Done

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

Please test

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

Pull request #7550 was updated.

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_3_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

please test for slc7_ppc64le_gcc11

@smuzaffar
Copy link
Contributor

please test for slc7_aarch64_gcc11

@smuzaffar
Copy link
Contributor

please test for cs8_amd64_gcc10

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e64a53/21930/summary.html
COMMIT: f4450de
CMSSW: CMSSW_12_3_X_2022-01-23-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7550/21930/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3465668
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3465634
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 42 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e64a53/21942/summary.html
COMMIT: f4450de
CMSSW: CMSSW_12_3_X_2022-01-21-2300/slc7_aarch64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7550/21942/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

/data/cmsbuild/jenkins_b/workspace/ib-run-pr-tests/testBuildDir/slc7_aarch64_gcc11/external/gcc/11.2.1-f478fee2760dbd22aaabb4e3a8fe1640/bin/c++ -g -O3 -rdynamic CMakeFiles/igprof-analyse.dir/src/analyse.cc.o -o igprof-analyse  -Wl,-rpath,/data/cmsbuild/jenkins_b/workspace/ib-run-pr-tests/testBuildDir/slc7_aarch64_gcc11/external/pcre/8.43-e6b3d6f8e1424033990367f0ae94d8f3/lib: -ldl /data/cmsbuild/jenkins_b/workspace/ib-run-pr-tests/testBuildDir/slc7_aarch64_gcc11/external/pcre/8.43-e6b3d6f8e1424033990367f0ae94d8f3/lib/libpcre.so 
make[2]: Leaving directory `/data/cmsbuild/jenkins_b/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_aarch64_gcc11/external/igprof/5.9.16-0818e13c4488676f1e25c5baa08aba56/build'
[ 95%] Built target igprof-analyse
make[1]: Leaving directory `/data/cmsbuild/jenkins_b/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_aarch64_gcc11/external/igprof/5.9.16-0818e13c4488676f1e25c5baa08aba56/build'
make: *** [all] Error 2
error: Bad exit status from /data/cmsbuild/jenkins_b/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.gA08yd (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+igprof+5.9.16-0818e13c4488676f1e25c5baa08aba56
Bad exit status from /data/cmsbuild/jenkins_b/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.gA08yd (%build)


@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e64a53/21943/summary.html
COMMIT: f4450de
CMSSW: CMSSW_12_3_X_2022-01-23-0000/slc7_ppc64le_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7550/21943/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e64a53/21943/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e64a53/21943/git-merge-result

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e64a53/21941/summary.html
COMMIT: f4450de
CMSSW: CMSSW_12_3_X_2022-01-21-2300/cs8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7550/21941/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e64a53/21941/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e64a53/21941/git-merge-result

Build

I found compilation error when building:

    raise RuntimeError("failed to load library '"+options.library+"'")
RuntimeError: failed to load library 'libAnalysisDataFormatsTrackInfo.so'
>> Checking EDM Class Transients in libCalibrationEcalTBTools.so
Suggestion: You can run 'scram build updateclassversion' to generate src/AnalysisDataFormats/TrackInfo/src/classes_def.xml.generated with updated ClassVersion
TFile::Init:0: RuntimeWarning: no StreamerInfo found in /cvmfs/cms-ib.cern.ch/nweek-02716/cs8_amd64_gcc10/cms/cmssw/CMSSW_12_3_X_2022-01-18-2300/lib/cs8_amd64_gcc10/SimDataFormatsEncodedEventId_xr_rdict.pcm therefore preventing schema evolution when reading this file. The file was produced with version 6.22/09 of ROOT.
gmake: *** [tmp/cs8_amd64_gcc10/edm_checks/libAnalysisDataFormatsTrackInfo.so] Error 1
@@@@ ----> OK  EDM Class Version 
@@@@ ----> OK  EDM Class Version 
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Version for src/CondFormats/Alignment/src/classes_def.xml in libCondFormatsAlignment.so
>> Checking EDM Class Transients in libCUDADataFormatsTrackingRecHit.so


@smuzaffar smuzaffar merged commit c28548e into IB/CMSSW_12_3_X/master Jan 23, 2022
@smuzaffar smuzaffar deleted the add-libzmq branch January 23, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants