Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT626] Root update v6 26 00 patches #8131

Conversation

aandvalenzuela
Copy link
Contributor

No description provided.

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_12_6_X/rootnext.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28a0bc/28298/summary.html
COMMIT: bfbb2bd
CMSSW: CMSSW_12_6_ROOT626_X_2022-10-16-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8131/28298/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testSiStripDQM_OfflineTkMap had ERRORS

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-28a0bc/2500.601_mc126X+TTBarMINIAOD12.6+NANO_mc12.6+HRV_NANO_mc

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16684 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3391158
  • DQMHistoTests: Total failures: 42314
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3348821
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.638 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -0.078 KiB HLT/B2G
  • DQMHistoSizes: changed ( 11834.0 ): -0.170 KiB SiStrip/MechanicalView
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 5 / 46 workflows

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28a0bc/28341/summary.html
COMMIT: bfbb2bd
CMSSW: CMSSW_12_6_ROOT626_X_2022-10-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8131/28341/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 19064 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3391158
  • DQMHistoTests: Total failures: 46189
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3344946
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.584 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 2.584 KiB SiStrip/MechanicalView
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 6 / 46 workflows

@smuzaffar
Copy link
Contributor

tests looks good but we waitfor ROOT626 validation before updating it

@smuzaffar smuzaffar closed this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants