-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BuildRules] Reorder Rocm flags so that those can override compilers flags #8285
Conversation
smuzaffar
commented
Feb 2, 2023
•
edited
Loading
edited
- Reorder Rocm flags so that those can override compilers flags
- Make ROCM_HOST and CUDA_HOST flags to match the other flags names e.g
- REM_ROCM_HOST instead of ROCM_HOST_REM
- REM_CUDA_HOST instead of CUDA_HOST_REM
- Allow to add/remove cuda/rocm host flags via project config/BuildFile e.g. to remove special flags for ASAN/UBSAN which does bot work with rocm/cuda
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_0_X/master. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
test parameters:
|
please test |
Pull request #8285 was updated. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1787ea/30371/summary.html Comparison SummarySummary:
|