Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontier client to version 2.10.2 #8550

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Jun 16, 2023

  • Update frontier cline tto version 2.10.2
  • Use frontier client sources directly from http://frontier.cern.ch/dist as we do not have any CMS specific patches to apply
  • Update pacparser 1.4.2 which contains security fix for GHSA-62q6-v997-f7v9

This resolves #8549

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_2_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #8550 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6842a8/33197/summary.html
COMMIT: ed0132b
CMSSW: CMSSW_13_2_X_2023-06-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8550/33197/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation warning when building: See details on the summary page.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8550 was updated.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6842a8/33198/summary.html
COMMIT: d51981f
CMSSW: CMSSW_13_2_X_2023-06-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8550/33198/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Patch #0 (pacparser-python-fix):
+ patch --no-backup-if-mismatch -p1 --fuzz=0
patching file tests/runtests.py
Hunk #1 FAILED at 26.
1 out of 1 hunk FAILED -- saving rejects to file tests/runtests.py.rej
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.lC8l6g (%prep)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+pacparser+1.4.2-c4fe22f0bf954054330d4d4924a20c92
Macro expanded in comment on line 350: %{pkginstroot}/${PYTHON3_LIB_SITE_PACKAGES}


@smuzaffar smuzaffar force-pushed the smuzaffar-patch-1 branch from d51981f to 1faa148 Compare June 16, 2023 06:32
@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #8550 was updated.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6842a8/33199/summary.html
COMMIT: 1faa148
CMSSW: CMSSW_13_2_X_2023-06-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8550/33199/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196062
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196033
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please upgrade frontier_client to 2.10.2
2 participants