Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop py3-Theano, py3-downhill and py3-hep_ml #8562

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

iarspider
Copy link
Contributor

@iarspider iarspider commented Jun 22, 2023

These packages are unmaintaned and incompatible with newer versions of py3-numpy

@iarspider iarspider changed the title Drop py3-Theano, py3-downhill and py3-hep_ml: unmaintaned and incompa… Drop py3-Theano, py3-downhill and py3-hep_ml Jun 22, 2023
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_2_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor

@iarspider , you need to cleanup the specs to remove the dependency on these package e.g
https://github.com/search?q=repo%3Acms-sw%2Fcmsdist%20Theano&type=code

@cmsbuild
Copy link
Contributor

Pull request #8562 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bd9ed/33339/summary.html
COMMIT: 826172d
CMSSW: CMSSW_13_2_X_2023-06-22-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8562/33339/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3200270
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3200245
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar merged commit d34e50e into IB/CMSSW_13_2_X/master Jun 22, 2023
@iarspider iarspider deleted the drop-py3-theano-downhill-hepml branch June 23, 2023 09:24
@iarspider iarspider restored the drop-py3-theano-downhill-hepml branch June 23, 2023 09:24
@smuzaffar smuzaffar deleted the drop-py3-theano-downhill-hepml branch July 24, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants