Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[G4VECGEOM] Update Geant4 to 11.1.ref07 #8632

Merged
merged 4 commits into from
Aug 5, 2023

Conversation

iarspider
Copy link
Contributor

No description provided.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2023

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_3_X/g4_vecgeom.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2023

Pull request #8632 was updated.

geant4.spec Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-def276/34049/summary.html
COMMIT: 949f5fd
CMSSW: CMSSW_13_3_G4VECGEOM_X_2023-08-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8632/34049/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 26365 lines from the logs
  • Reco comparison results: 62270 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150821
  • DQMHistoTests: Total failures: 148120
  • DQMHistoTests: Total nulls: 229
  • DQMHistoTests: Total successes: 3002450
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 10.118000000000002 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.063 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): 3.111 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.059 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -1.222 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 3.224 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): 4.883 KiB SiStrip/MechanicalView
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 18 / 46 workflows

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2023

Pull request #8632 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2023

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-def276/34073/summary.html
COMMIT: ed47b3a
CMSSW: CMSSW_13_3_G4VECGEOM_X_2023-08-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8632/34073/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling bigobj /pool/condor/dir_256193/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_G4VECGEOM_X_2023-08-02-2300/src/SimG4Core/Generators/src/Generator.cc
>> Compiling bigobj /pool/condor/dir_256193/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_G4VECGEOM_X_2023-08-02-2300/src/SimG4Core/Generators/src/HepMCParticle.cc
>> Compiling bigobj /pool/condor/dir_256193/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_G4VECGEOM_X_2023-08-02-2300/src/SimG4Core/Generators/src/LumiMonitorFilter.cc
>> Building shared library tmp/el8_amd64_gcc11/src/SimG4Core/Generators/src/SimG4CoreGenerators/libSimG4CoreGenerators.so
/pool/condor/dir_256193/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.4.1-30ebdc301ebd200f2ae0e3d880258e65/bin/../lib/gcc/x86_64-redhat-linux-gnu/11.4.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lG4persistency: No such file or directory
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc11/src/SimG4Core/Generators/src/SimG4CoreGenerators/libSimG4CoreGenerators.so] Error 1
Leaving library rule at SimG4Core/Generators
>> Building  big object file tmp/el8_amd64_gcc11/src/SimG4Core/Generators/src/SimG4CoreGenerators/bigobj/SimG4CoreGenerators.obj
>> Leaving Package SimG4Core/Generators
>> Package SimG4Core/Generators built


@civanch
Copy link
Contributor

civanch commented Aug 4, 2023

@iarspider , there are two set of G4 libraries: geant4core and geant4vis. This problem means that the second is not compiled properly or we need to move G4persistency from vis to core, because cmake of Geant4 were changed. Most likely we have to review both spec files

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2023

Pull request #8632 was updated.

@iarspider
Copy link
Contributor Author

please test

@smuzaffar smuzaffar merged commit 27ec6ac into IB/CMSSW_13_3_X/g4_vecgeom Aug 5, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-def276/34097/summary.html
COMMIT: 79cb1bf
CMSSW: CMSSW_13_3_G4VECGEOM_X_2023-08-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8632/34097/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-def276/34097/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-def276/34097/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 26357 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 63438 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150821
  • DQMHistoTests: Total failures: 155334
  • DQMHistoTests: Total nulls: 190
  • DQMHistoTests: Total successes: 2995275
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.3039999999999998 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.117 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): -0.586 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.234 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.129 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 1.644 KiB SiStrip/MechanicalView
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 18 / 46 workflows

@smuzaffar smuzaffar deleted the g4vecgeom-11.1.7 branch August 6, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants