Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert lhapdf to 6.4.0 but keep lhapdh_dataset 6.5.1c #8869

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

smuzaffar
Copy link
Contributor

See cms-sw/cmssw#43526 for detail on this revert.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_14_0_X/master.

@iarspider, @aandvalenzuela, @cmsbuild, @smuzaffar can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

test parameters:

  • relval = 132.0
  • enable = threading
  • relval_threading = 132.0

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d68eb/36401/summary.html
COMMIT: 2d114a9
CMSSW: CMSSW_14_0_X_2023-12-10-2300/el8_amd64_gcc12
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8869/36401/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mkirsano
Copy link
Contributor

I agree with this. revert. I would not be as simple as this to revert the sets.

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit 87c0299 into IB/CMSSW_14_0_X/master Dec 12, 2023
11 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants