Rivet 3.1.10 and Yoda 1.9.10

[mseidel42]

Version bump, will provide code updates if necessary

[cmsbuild]

A new Pull Request was created by @mseidel42 (Markus Seidel) for branch IB/CMSSW_14_1_X/master.

@aandvalenzuela, @smuzaffar, @cmsbuild, @iarspider can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[smuzaffar]

please test

[cmsbuild]

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb199e/37377/summary.html
COMMIT: 86a772b
CMSSW: CMSSW_14_1_X_2024-02-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9006/37377/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

patching file include/YODA/Utils/BinSearcher.h
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file include/YODA/Utils/BinSearcher.h.rej
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.fQOj9l (%prep)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+yoda+1.9.10-4fc6a7d5988a0c0772c71e1cc684e4c0
Macro expanded in comment on line 365: %{pkginstroot}/${PYTHON3_LIB_SITE_PACKAGES}


[smuzaffar]

@mseidel42 , looks like patch for first two files in https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_14_1_X/master/rivet-deprecated-warn.patch are not needed any more. Can you check and update the patch ?

[cmsbuild]

Pull request #9006 was updated.

[smuzaffar]

@mseidel42 , I think https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_14_1_X/master/rivet-deprecated-warn.patch also needs cleanup ... right?

[cmsbuild]

Pull request #9006 was updated.

[mseidel42]

Ah sorry, I saw only the YODA in the log. Reverted the Rivet patches as well, they are all in the main repo now :)

[iarspider]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb199e/37405/summary.html
COMMIT: 6e7721c
CMSSW: CMSSW_14_1_X_2024-02-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9006/37405/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin src/GeneratorInterface/RivetInterface/plugins/ParticleLevelProducer.cc
>> Compiling edm plugin src/GeneratorInterface/RivetInterface/plugins/RivetAnalyzer.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-02-12-2300/src/GeneratorInterface/RivetInterface/interface/ParticleLevelProducer.h:16,
                 from src/GeneratorInterface/RivetInterface/plugins/ParticleLevelProducer.cc:3:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-02-12-2300/src/GeneratorInterface/RivetInterface/interface/RivetAnalysis.h: In member function 'virtual void Rivet::RivetAnalysis::init()':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-02-12-2300/src/GeneratorInterface/RivetInterface/interface/RivetAnalysis.h:108:118: error: use of deleted function 'Rivet::DressedLeptons& Rivet::DressedLeptons::operator=(Rivet::DressedLeptons&&)'
  108 |         dressed_leptons = DressedLeptons(photons, charged_leptons, _lepConeSize, lepton_cut, /*useDecayPhotons*/ true);
      |                                                                                                                      ^
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-02-12-2300/src/GeneratorInterface/RivetInterface/interface/RivetAnalysis.h:15:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/rivet/3.1.10-db4f2a9a62a5db7ac7f4dd33abfdf83f/include/Rivet/Projections/DressedLeptons.hh:61:9: note: 'Rivet::DressedLeptons& Rivet::DressedLeptons::operator=(Rivet::DressedLeptons&&)' is implicitly deleted because the default definition would be ill-formed:
   61 |   class DressedLeptons : public FinalState {


[smuzaffar]

@mseidel42 , looks like we need cmssw updates to go with this

[smuzaffar]

@mseidel42 , it could be the ordering of files when rivet build system tries to run g++ -o "RivetATLASAnalyses.so" -shared -fPIC <list-of-plugin-sources>. May be adding the missing #include "Rivet/Projections/VetoedFinalState.hh" in pluginATLAS/ATLAS_2023_I2663725.cc fix this issue

[cmsbuild]

Pull request #9006 was updated.

[iarspider]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb199e/37641/summary.html
COMMIT: 17b10ee
CMSSW: CMSSW_14_1_X_2024-02-22-2300/el8_amd64_gcc12
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9006/37641/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @ossobooker Updates DT Calibration to 14_0_X and includes fixes for the HI workflow cmssw#43963
• @Dr15Jones Add wildcards to generated _cfi.py files cmssw#44013
• @iarspider-cmssw Fix wildcard imports from ROOT (they are forbidden now) cmssw#43974
• @fwyzard Let tests fail gracefully if no devices are found cmssw#44036
• @fabiocos MTD geometry: update pixel index definition from RectangularMTDTopology cmssw#44051
• @missirol print total number of Paths in hltIntegrationTests cmssw#44055
• @mmusich Fix customizeHLTforAlpakaParticleFlowClustering: insert DQM_HcalReconstruction_v only if present in the HLT menu cmssw#44048
• @Mmiglio Update L1Scouting Data Format tests and minor code fixes  cmssw#43984
• @forthommel CepGen 1.2.0 #9030

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb199e/37641/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fb199e/37641/git-merge-result

Unit Tests

I found 2 errors in the following unit tests:

---> test TestL1ScoutingFormat had ERRORS
---> test TestSDSRawDataCollectionFormat had ERRORS

Comparison Summary

Summary:

• You potentially added 90 lines to the logs
• Reco comparison results: 420 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3247143
• DQMHistoTests: Total failures: 2216
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3244905
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 204 log files, 163 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[iarspider]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#43973

[cmsbuild]

REMINDER @sextonkennedy, @antoniovilela, @rappoccio: This PR was tested with cms-sw/cmssw#43973, please check if they should be merged together

[antoniovilela]

ignore tests-rejected with external-failure

[antoniovilela]

+1