Change hls4ml emulator extra version to avoid segfault

[aloeliger]

This PR upgrades the version of hls4mlEmulatorExtras to avoid a segfault on failure to load model needed for AXO error handling in cms-sw/cmssw#44054

The new release can be seen here: https://github.com/cms-hls4ml/hls4mlEmulatorExtras/releases/tag/v1.1.2

the only changed introduced is this cms-hls4ml/hls4mlEmulatorExtras#4

A backport will be required to 14_0 for AXO's backport to this same release

[cmsbuild]

A new Pull Request was created by @aloeliger for branch IB/CMSSW_14_1_X/master.

@cmsbuild, @iarspider, @smuzaffar, @aandvalenzuela can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[aloeliger]

please test

[makortel]

The fix in cms-hls4ml/hls4mlEmulatorExtras#4 is not sufficient, because the hls4mlEmulator::ModelLoader::model_lib_ is not initialized to nullptr in the constructor.

[aloeliger]

The fix in cms-hls4ml/hls4mlEmulatorExtras#4 is not sufficient, because the hls4mlEmulator::ModelLoader::model_lib_ is not initialized to nullptr in the constructor.

@makortel I can change this further, but in tests recreating the issue, it did fix the segfault preventing error handling.

[makortel]

The fix in cms-hls4ml/hls4mlEmulatorExtras#4 is not sufficient, because the hls4mlEmulator::ModelLoader::model_lib_ is not initialized to nullptr in the constructor.

@makortel I can change this further, but in tests recreating the issue, it did fix the segfault preventing error handling.

I believe that can happen, but it relies on undefined behavior, and therefore can still lead to segfaults at any time.

[cmsbuild]

Pull request #9064 was updated.

[aloeliger]

@makortel I have added a change in cms-hls4ml/hls4mlEmulatorExtras#5 and https://github.com/cms-hls4ml/hls4mlEmulatorExtras/releases/tag/v1.1.3 that initializes model_lib_ to nullptr to change to defined behavior here.

[aloeliger]

please test

[makortel]

Thanks!

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-515558/38070/summary.html
COMMIT: 36677c8
CMSSW: CMSSW_14_1_X_2024-03-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9064/38070/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 16 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 2807 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297383
• DQMHistoTests: Total failures: 5665
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3291698
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.011 KiB( 47 files compared)
• DQMHistoSizes: changed ( 250202.181 ): -0.011 KiB SiStrip/MechanicalView
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 1 / 46 workflows

[smuzaffar]

+externals

Looks like this was needed for cms-sw/cmssw#44054

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

backport done
Successfully backported PR #9064 as #9074 for branch IB/CMSSW_14_0_X/master