AXOL1TL v3.0.2

[jmduarte]

This updates AXOL1TL to v3.0.2 adding namespace protection to weights, biases, and model function as done for CICADA in #9087 to prevent symbol name clashes.

[cmsbuild]

A new Pull Request was created by @jmduarte for branch IB/CMSSW_14_1_X/master.

@iarspider, @aandvalenzuela, @smuzaffar, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[aloeliger]

please test

[cmsbuild]

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-227e11/38350/summary.html
COMMIT: c0080c2
CMSSW: CMSSW_14_1_X_2024-03-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9091/38350/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

Requested to quit.
* The action "build-external+AXOL1TL+3.0.1-7c1cb7d0a8d18d43da363569f8a4a555" was not completed successfully because Failed to build AXOL1TL. Log file in /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/AXOL1TL/3.0.1-7c1cb7d0a8d18d43da363569f8a4a555/log. Final lines of the log file:
27 |         unscaled_t tmp0 = unscaled[i] - ad_offsets[i];
|                                         ^~~~~~~~~~
|                                         ad_offset_t
GTADModel_emulator_v1.cpp:28:32: error: 'ad_shift' was not declared in this scope; did you mean 'ad_shift_t'?
28 |         input_t tmp1 = tmp0 >> ad_shift[i];
|                                ^~~~~~~~
|                                ad_shift_t
make[1]: *** [Makefile:10: GTADModel_emulator_v1.o] Error 1
make[1]: *** Waiting for unfinished jobs....


[cmsbuild]

Pull request #9091 was updated.

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-227e11/38354/summary.html
COMMIT: 8a7d45d
CMSSW: CMSSW_14_1_X_2024-03-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9091/38354/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 108 lines from the logs
• Reco comparison results: 51 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297369
• DQMHistoTests: Total failures: 107
• DQMHistoTests: Total nulls: 3
• DQMHistoTests: Total successes: 3297239
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 30.714 KiB( 47 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 5.119 KiB MTD/Vertices
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 7 / 46 workflows

[smuzaffar]

assign l1

[cmsbuild]

New categories assigned: l1

@epalencia,@aloeliger you have been requested to review this Pull request/Issue and eventually sign? Thanks

[smuzaffar]

+externals

@cms-sw/l1-l2 , please review this AXOL1TL update

[aloeliger]

The changes to AXOL1TL triggers in this PR are both expected, and desired.

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)