Updated root to tip of branch v6-30-00-patches

[iarspider]

No description provided.

[cmsbuild]

A new Pull Request was created by @iarspider for branch IB/CMSSW_14_1_X/master.

@iarspider, @aandvalenzuela, @cmsbuild, @smuzaffar can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[iarspider]

please test

[smuzaffar]

root 6.30 changes are root-project/root@dcf4d2a...8f594ff
@makortel @Dr15Jones, any objection on get these in 14.1.X default IBs (I see there are some thread safety related changes too) ?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-68e900/39353/summary.html
COMMIT: 91aafb6
CMSSW: CMSSW_14_1_X_2024-05-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9189/39353/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 170 lines from the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3335848
• DQMHistoTests: Total failures: 851
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3334977
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

@smuzaffar as long as our tests and RelVals pass, I don't have any objections.

[makortel]

root 6.30 changes are root-project/root@dcf4d2a...8f594ff
@makortel @Dr15Jones, any objection on get these in 14.1.X default IBs (I see there are some thread safety related changes too) ?

Let's get them in. I see commits from root-project/root#15113, that are needed to address cms-sw/cmssw#33084, and root-project/root#15459, that was motivated by cms-sw/cmssw#44670.

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-68e900/39364/summary.html
COMMIT: 91aafb6
CMSSW: CMSSW_14_1_X_2024-05-13-1100/el8_amd64_gcc12
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9189/39364/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 17 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 62 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3325996
• DQMHistoTests: Total failures: 971
• DQMHistoTests: Total nulls: 72
• DQMHistoTests: Total successes: 3324933
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 777.594 KiB( 47 files compared)
• DQMHistoSizes: changed ( 12834.0,... ): 83.939 KiB HLT/EGM
• DQMHistoSizes: changed ( 12834.0,... ): 35.131 KiB HLT/HLTEgammaValidation
• DQMHistoSizes: changed ( 12834.0,... ): 7.070 KiB HLT/Filters
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 6 / 46 workflows

[smuzaffar]

PR DQM/reco comparison show a lot of differences

[Dr15Jones]

I believe differences when using threads is expected. Was the results of the non-thread case also problematic?

[smuzaffar]

DQM/reco comparison is only run for non-threaded runs.

[makortel]

Would it make sense to rerun the tests (without the threading, just to make sure)? The earlier tests did not show unexpected differences.

[smuzaffar]

sure I can re-run it once 11h00 IB is available. By the way #9189 (comment) are without threading

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-68e900/39392/summary.html
COMMIT: 91aafb6
CMSSW: CMSSW_14_1_X_2024-05-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9189/39392/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338976
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338947
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[makortel]

sure I can re-run it once 11h00 IB is available. By the way #9189 (comment) are without threading

Right. There the comparison differences are in 12834.7 that are known to be spurious cms-sw/cmssw#39803

[makortel]

Last round of tests looks clean

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)