Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport alpaka#2295: Fix memcpy warning #9376

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 22, 2024

Backport alpaka-group/alpaka#2295 to alpaka 1.1.0.

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 22, 2024

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 22, 2024

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard for branch IB/CMSSW_14_1_X/master.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 22, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-947eef/41092/summary.html
COMMIT: 185da82
CMSSW: CMSSW_14_1_X_2024-08-22-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9376/41092/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-947eef/41092/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-947eef/41092/git-merge-result

Unit Tests

I found 6 errors in the following unit tests:

---> test createDBObjects had ERRORS
---> test PrimaryVertex had ERRORS
---> test testPhase2SkimmedGeometry had ERRORS
and more ...

Comparison Summary

Summary:

  • You potentially added 18 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328166
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3328143
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 9.636000000000001 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 24834.911,... ): 1.606 KiB MTD/Vertices
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 23, 2024

The errors are

ModuleNotFoundError: No module named 'Configuration.Geometry.GeometryExtended2026D88Reco_cff'

which are likely independent from this PR.

@makortel
Copy link
Contributor

The errors are

ModuleNotFoundError: No module named 'Configuration.Geometry.GeometryExtended2026D88Reco_cff'

which are likely independent from this PR.

Right, there is a PR to fix those cms-sw/cmssw#45764

@makortel
Copy link
Contributor

ignore tests-rejected with ib-failure

@makortel
Copy link
Contributor

@cms-sw/externals-l2 @cms-sw/orp-l2 If there is a chance to get this in 14_1_0_pre7, that would be great (although theoretically backporting it to 14_1_X afterwards should be straightforward too).

@iarspider
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@iarspider
Copy link
Contributor

merge

@iarspider iarspider merged commit fa4c1bc into cms-sw:IB/CMSSW_14_1_X/master Aug 23, 2024
11 of 12 checks passed
@fwyzard fwyzard deleted the IB/CMSSW_14_1_X/master_alpaka_backport_2295 branch February 2, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants