Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python 3.12] Fixes for slc7 #9414

Merged
merged 6 commits into from
Sep 21, 2024
Merged

[Python 3.12] Fixes for slc7 #9414

merged 6 commits into from
Sep 21, 2024

Conversation

iarspider
Copy link
Contributor

@iarspider iarspider commented Sep 19, 2024

xrootd and matplotlib are still failing. Also, Python is built without ssl module (needs newer OpenSSL)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_14_2_X/py312.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #9414 was updated.

@cmsbuild
Copy link
Contributor

Pull request #9414 was updated.

@smuzaffar
Copy link
Contributor

please test for el8_amd64_gcc12

@cmsbuild
Copy link
Contributor

Pull request #9414 was updated.

@smuzaffar
Copy link
Contributor

please test for el8_amd64_gcc12

@iarspider , 6448918 allows to build matplotlib for slc7

@cmsbuild
Copy link
Contributor

Pull request #9414 was updated.

@smuzaffar
Copy link
Contributor

please test for el8_amd64_gcc12

@smuzaffar
Copy link
Contributor

please test for el8_amd64_gcc12

@cmsbuild
Copy link
Contributor

Pull request #9414 was updated.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fde6a/41641/summary.html
COMMIT: ca35e70
CMSSW: CMSSW_14_2_PY312_X_2024-09-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9414/41641/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

inlined from 'virtual Bool_t TCling::IsLoaded(const char*) const' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.30.09-7886c40a021b7e9169de574f86de366e/root-6.30.09/core/metacling/src/TCling.cxx:3153:25:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/char_traits.h:435:56: warning: 'void* __builtin_memcpy(void*, const void*, long unsigned int)' accessing 9223372036854775810 or more bytes at offsets [2, 9223372036854775807] and 1 may overlap up to 9223372036854775813 bytes at offset -3 [-Wrestrict]
435 |         return static_cast(__builtin_memcpy(__s1, __s2, __n));
|                                        ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
ninja: build stopped: subcommand failed.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.RyR2k3 (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: lcg+root+6.30.09-7886c40a021b7e9169de574f86de366e
Macro expanded in comment on line 383: %{pkginstroot}/lib


@smuzaffar
Copy link
Contributor

please test for el8_amd64_gcc12

@smuzaffar
Copy link
Contributor

please test for el8_amd64_gcc12

@cmsbuild
Copy link
Contributor

Pull request #9414 was updated.

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fde6a/41675/summary.html
COMMIT: b3222ab
CMSSW: CMSSW_14_2_PY312_X_2024-09-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9414/41675/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

inlined from 'virtual Bool_t TCling::IsLoaded(const char*) const' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/lcg/root/6.30.09-fc5c27e5d19f5f8afaa9e891836e3f3e/root-6.30.09/core/metacling/src/TCling.cxx:3153:25:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/char_traits.h:435:56: warning: 'void* __builtin_memcpy(void*, const void*, long unsigned int)' accessing 9223372036854775810 or more bytes at offsets [2, 9223372036854775807] and 1 may overlap up to 9223372036854775813 bytes at offset -3 [-Wrestrict]
435 |         return static_cast(__builtin_memcpy(__s1, __s2, __n));
|                                        ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
ninja: build stopped: subcommand failed.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.c7mPwV (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: lcg+root+6.30.09-fc5c27e5d19f5f8afaa9e891836e3f3e
Macro expanded in comment on line 383: %{pkginstroot}/lib


@smuzaffar
Copy link
Contributor

please test for el8_amd64_gcc12

@cmsbuild
Copy link
Contributor

Pull request #9414 was updated.

@smuzaffar
Copy link
Contributor

+externals

looks good to go in for py312

@smuzaffar smuzaffar merged commit d521f8a into IB/CMSSW_14_2_X/py312 Sep 21, 2024
7 of 9 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_2_X/py312 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fde6a/41681/summary.html
COMMIT: 0758fd3
CMSSW: CMSSW_14_2_PY312_X_2024-09-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9414/41681/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fde6a/41681/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fde6a/41681/git-merge-result

Unit Tests

I found 3 errors in the following unit tests:

---> test TestFWCoreParameterSetDriver had ERRORS
---> test dxr-build had ERRORS
---> test import-histbook had ERRORS

Comparison Summary

Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants