add protection against time-inverted IOVs in the comparator script

cms-sw · Oct 16, 2024 · 953ee39 · 953ee39
1 parent be4adbc
commit 953ee39
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/CondCore/SiStripPlugins/scripts/SiStripG2GainsValidator b/CondCore/SiStripPlugins/scripts/SiStripG2GainsValidator
@@ -23,6 +23,7 @@ def getCommandOutput(command):
     if err:
         print ('%s failed w/ exit code %d' % (command, err))
         sys.exit(1)  # This will stop the script immediately with the failure exit code
+    print(data)
     return data
 
 ##############################################

diff --git a/CondCore/SiStripPlugins/scripts/testCompareSiStripG2Gains.sh b/CondCore/SiStripPlugins/scripts/testCompareSiStripG2Gains.sh
@@ -24,6 +24,12 @@ W_DIR=$(pwd)
 STARTIOV=$2
 ENDIOV=$3
 
+# Check if ENDIOV is greater than or equal to STARTIOV
+if (( $ENDIOV < $STARTIOV )); then
+    echo "Error: ENDIOV ($ENDIOV) is less than STARTIOV ($STARTIOV). Skipping comparisons"
+    exit 0
+fi
+
 source /cvmfs/cms.cern.ch/cmsset_default.sh
 eval "$(scram run -sh)"