minor changes to improve the coding

cms-sw · Jan 25, 2023 · d6a1755 · d6a1755
1 parent 3fac2a3
commit d6a1755
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/L1Trigger/CSCTriggerPrimitives/interface/CSCCathodeLCTProcessor.h b/L1Trigger/CSCTriggerPrimitives/interface/CSCCathodeLCTProcessor.h
@@ -166,11 +166,12 @@ class CSCCathodeLCTProcessor : public CSCBaseboard {
 
   /** Dump half-strip digis */
   void dumpDigis(
-      const std::vector<int> strip[CSCConstants::NUM_LAYERS][CSCConstants::MAX_NUM_HALF_STRIPS_RUN2_TRIGGER]) const;
+      const std::vector<int> halfstrip[CSCConstants::NUM_LAYERS][CSCConstants::MAX_NUM_HALF_STRIPS_RUN2_TRIGGER]) const;
 
   /* check whether there is a shower around best CLCT */
   void checkLocalShower(
-      int zone, const std::vector<int> strip[CSCConstants::NUM_LAYERS][CSCConstants::MAX_NUM_HALF_STRIPS_RUN2_TRIGGER]);
+      int zone,
+      const std::vector<int> halfstrip[CSCConstants::NUM_LAYERS][CSCConstants::MAX_NUM_HALF_STRIPS_RUN2_TRIGGER]);
 
   void encodeHighMultiplicityBits();
 

diff --git a/L1Trigger/CSCTriggerPrimitives/python/params/tmbParams.py b/L1Trigger/CSCTriggerPrimitives/python/params/tmbParams.py
@@ -52,7 +52,7 @@
     # ALCT-CLCT stays at 7 for the moment
     matchTrigWindowSize = 7,
     #use CLCT sorted by Bx only for ALCT-CLCTmatch for now
-    sortClctBx = cms.bool(True),
+    sortClctBx = True,
     # LCTs found in the window [5, 6, 7, 8, 9, 10, 11] are good
     tmbL1aWindowSize = 7,
     tmbDropUsedClcts = False,

diff --git a/L1Trigger/CSCTriggerPrimitives/src/CSCCathodeLCTProcessor.cc b/L1Trigger/CSCTriggerPrimitives/src/CSCCathodeLCTProcessor.cc
@@ -417,10 +417,7 @@ void CSCCathodeLCTProcessor::checkLocalShower(
           totalHits++;
     }
 
-    if (totalHits >= localShowerThresh)
-      localShowerFlag[bx] = true;
-    else
-      localShowerFlag[bx] = false;
+    localShowerFlag[bx] = totalHits >= localShowerThresh;
     if (infoV > 1)
       LogDebug("CSCCathodeLCTProcessor") << " bx " << bx << " bestCLCT key HS " << keyHS
                                          << " localshower zone: " << minHS << ", " << maxHS << " totalHits "