Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECAL GPU validation DQM follow up actions after PR #36742 #37025

Closed
3 tasks done
thomreis opened this issue Feb 22, 2022 · 15 comments
Closed
3 tasks done

ECAL GPU validation DQM follow up actions after PR #36742 #37025

thomreis opened this issue Feb 22, 2022 · 15 comments

Comments

@thomreis
Copy link
Contributor

thomreis commented Feb 22, 2022

In order to merge the ECAL GPU validation DQM PR #36742 a couple of tasks have been postponed to be done in follow up PRs.

@alejands @fwyzard @jfernan2

@cmsbuild
Copy link
Contributor

A new Issue was created by @thomreis Thomas Reis.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

assign dqm

@cmsbuild
Copy link
Contributor

New categories assigned: dqm

@jfernan2,@ahmad3213,@rvenditti,@emanueleusai,@pbo0,@pmandrik you have been requested to review this Pull request/Issue and eventually sign? Thanks

@fwyzard
Copy link
Contributor

fwyzard commented Feb 23, 2022

assign ecal-dpg

@fwyzard
Copy link
Contributor

fwyzard commented Feb 23, 2022

assign heterogeneous

@cmsbuild
Copy link
Contributor

New categories assigned: heterogeneous,ecal-dpg

@fwyzard,@simonepigazzini,@makortel,@jainshilpi,@thomreis you have been requested to review this Pull request/Issue and eventually sign? Thanks

@thomreis
Copy link
Contributor Author

2D histograms addressed in PR #38427

@thomreis
Copy link
Contributor Author

+ecal-dpg

@thomreis
Copy link
Contributor Author

+1

@thomreis
Copy link
Contributor Author

Hi @smuzaffar why did signing with +ecal-dpg not work here?

@fwyzard
Copy link
Contributor

fwyzard commented Aug 31, 2022

+heterogeneous

@smuzaffar
Copy link
Contributor

Hi @smuzaffar why did signing with +ecal-dpg not work here?

@thomreis , bot was not recognizing - char in the category name. This has been fixed now ( cms-sw/cms-bot@1f3006f )

@thomreis
Copy link
Contributor Author

Thanks @smuzaffar

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2022

This issue is fully signed and ready to be closed.

@thomreis thomreis closed this as completed Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants