ECAL DQM GpuTask add 2D comparison histograms and enable GPU validation on online DQM

[alejands]

PR description:

The following additions are made to the ECAL DQM GPU validation module:

• Add in 2D histograms for comparing CPU and GPU generated values of ECAL digis, uncalibrated rec hits, and rec hits
• Create separate subdirectories for each ECAL object (digis, uncalibrated rec hits, rec hits) to reduce clutter with too many plots in one place
• Create more flags to be able to better customize what plots to make when running the module. Eg. for digis, enableDigi toggles running over GPU and CPU digi collections (creates CPU value 1D distribution and 1D GPU-CPU value difference by default), digi1D enables GPU value 1D distribution, and digi2D enables the 2D plots plots mentioned above
• Create separate dedicated client for GPU validation on ECAL online DQM

This PR addresses the remaining outstanding tasks in this issue: #37025

PR validation:

Online DQM configuration tested on test file provided by DQM-DC containing the new HLT collections. Offline DQM configuration tested on CPU-only and GPU WFs (runTheMatrix.py -w upgrade -l 11634.511,11634.512,11634.513).

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backports made to 12_3_X #38428 and 12_4_X #38429 for use in data taking

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38427/30633

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @alejands (Alejandro Sanchez) for master.

It involves the following packages:

• DQM/EcalMonitorTasks (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[fwyzard]

please test

[fwyzard]

enable gpu

[fwyzard]

please test

[fwyzard]

type new-feature

[fwyzard]

type ecal

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fb194/25629/summary.html
COMMIT: 1e53aa1
CMSSW: CMSSW_12_5_X_2022-06-19-2300/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38427/25629/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• You potentially added 242 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• Reco comparison had 3 failed jobs
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19864
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19856
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1980.436 KiB( 3 files compared)
• DQMHistoSizes: changed ( 11634.512 ): 990.218 KiB EcalBarrel/EBGpuTask
• DQMHistoSizes: changed ( 11634.512 ): 990.218 KiB EcalEndcap/EEGpuTask
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• You potentially added 40700 lines to the logs
• Reco comparison results: 81 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3659099
• DQMHistoTests: Total failures: 41
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3659035
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 73276.13500000004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): 990.218 KiB EcalBarrel/EBGpuTask
• DQMHistoSizes: changed ( 1000.0,... ): 990.218 KiB EcalEndcap/EEGpuTask
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38427/30721

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #38427 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fb194/25775/summary.html
COMMIT: d7f5f74
CMSSW: CMSSW_12_5_X_2022-06-24-2300/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38427/25775/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• Reco comparison had 3 failed jobs
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19864
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19856
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3665113
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3665071
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1