Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPU] Unit test testEigenGPUNoFit_t failing when testing inverse 5x5 #42460

Closed
aandvalenzuela opened this issue Aug 3, 2023 · 11 comments · Fixed by cms-sw/cmsdist#8782
Closed

Comments

@aandvalenzuela
Copy link
Contributor

aandvalenzuela commented Aug 3, 2023

Hello,

Unit test testEigenGPUNoFit_t (module RecoTracker/PixelTrackFitting) is failing when running TEST INVERSE 5x5 with:

===== Test "testEigenGPUNoFit_t" ====
TEST EIGENVALUES
TEST INVERSE 3x3
TEST INVERSE 4x4
TEST INVERSE 5x5
testEigenGPUNoFit_t: /tmp/avalenzu/CMSSW_13_3_GPU_X_2023-08-02-2300/src/RecoTracker/PixelTrackFitting/test/test_common.h:24: bool isEqualFuzzy(C1, C2, double) [with C1 = Eigen::Matrix<double, 5, 5>; C2 = Eigen::Matrix<double, 5, 5>]: Assertion `std::abs(a(i, j) - b(i, j)) < std::min(std::abs(a(i, j)), std::abs(b(i, j))) * epsilon' failed.
/bin/sh: line 1: 1044014 Aborted                 (core dumped) sh -c 'testEigenGPUNoFit_t '

---> test testEigenGPUNoFit_t had ERRORS
TestTime:4
^^^^ End Test testEigenGPUNoFit_t ^^^^                                         

We already had a similar issue when testing the 5x5 inverse in this unit test (See #33797).

I can reproduce it in lxplus-gpu nodes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2023

A new Issue was created by @aandvalenzuela Andrea Valenzuela.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Aug 3, 2023

assign reconstruction, heterogeneous

FYI @cms-sw/tracking-pog-l2 @VinInn

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2023

New categories assigned: heterogeneous,reconstruction

@mandrenguyen,@fwyzard,@clacaputo,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

@fwyzard
Copy link
Contributor

fwyzard commented Aug 3, 2023

Unit test testEigenGPUNoFit_t (module RecoTracker/PixelTrackFitting) is failing when running TEST INVERSE 5x5

When did it start to fail ?

@aandvalenzuela
Copy link
Contributor Author

It failed yesterday for the first time CMSSW_13_3_GPU_X_2023-08-01-2300 and today again CMSSW_13_3_GPU_X_2023-08-02-2300

@fwyzard
Copy link
Contributor

fwyzard commented Aug 3, 2023

@iarspider
Copy link
Contributor

@fwyzard are there any steps that we (externals) need to do to help triage this?

@fwyzard
Copy link
Contributor

fwyzard commented Oct 2, 2023

Is this still present after the latest Eigen update ?

@fwyzard
Copy link
Contributor

fwyzard commented Oct 2, 2023

OK.

I will try to set aside some time to look into it.

@fwyzard
Copy link
Contributor

fwyzard commented Oct 24, 2023

Should be fixed by cms-sw/cmsdist#8782 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants