Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the SFINAE check with static_assert #42425

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jul 31, 2023

PR description:

Works around a rare bug in nvcc/gcc that causes a function-static variable to be emitted as a local symbol instead of a unique global symbol.

PR validation:

Adding these changes on top of a setup that is failing as described in #42414 prevents the crash at the end of the job.

PR backports:

To be backported to CMSSW 13.0.x and 13.2.x to fix Alpaka-related developments and workflows.

Works around a rare bug in nvcc/gcc that causes a function-static
variable to be emitted as a local symbol instead of a unique global
symbol.
@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 31, 2023

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 31, 2023

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 31, 2023

fixes #42414

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 31, 2023

+heterogeneous

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42425/36431

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)

can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8eec5/33984/summary.html
COMMIT: 5a3261a
CMSSW: CMSSW_13_3_X_2023-07-31-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42425/33984/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150821
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3150793
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants