-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the SFINAE check with static_assert #42425
Replace the SFINAE check with static_assert #42425
Conversation
Works around a rare bug in nvcc/gcc that causes a function-static variable to be emitted as a local symbol instead of a unique global symbol.
type bugfix |
please test |
fixes #42414 |
+heterogeneous |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42425/36431
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages:
can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8eec5/33984/summary.html Comparison SummarySummary:
|
+1 |
PR description:
Works around a rare bug in nvcc/gcc that causes a function-static variable to be emitted as a local symbol instead of a unique global symbol.
PR validation:
Adding these changes on top of a setup that is failing as described in #42414 prevents the crash at the end of the job.
PR backports:
To be backported to CMSSW 13.0.x and 13.2.x to fix Alpaka-related developments and workflows.