AVXVec: replace 2*insertf128 with 1*_mm256_set_m128d

[iarspider]

PR description:

Fixes #36542, as suggested by @slava77 here

PR validation:

Bot tests

[iarspider]

please test for CMSSW_13_3_SKYLAKEAVX512_X

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42446/36453

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42446/36453/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42446/36453/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[iarspider]

please test for CMSSW_13_3_SKYLAKEAVX512_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42446/36454

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• DataFormats/Math (reconstruction)

@mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @fabiocos, @rovere, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e2102/34035/summary.html
COMMIT: c7084d7
CMSSW: CMSSW_13_3_SKYLAKEAVX512_X_2023-07-30-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42446/34035/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @iarspider [GCC13] Add include of cstdint in more places #42392
• @perrotta Maybe remove build warning in TrackerMap, but at least clean it up #42373
• @bsunanda Phase2-TB71 Add a new scenario to evaluate the August 2023 HGCal Test Beam #42429
• @fwyzard Replace the SFINAE check with static_assert #42425
• @caruta Removal of StringCutObjectSelector from Muon trigger DQM #42437
• @bsunanda Phase2-sim145 Study the difference in SD's between DDD and DD4hep for Phase2 scenarios #42420
• @smuzaffar [DBG] Fix comparison of integer expressions of different signedness #42405
• @iarspider Code changes for Protobuf 3.21.9 and TensorFlow 2.12 #42228
• @missirol fix configuration of GPU Pixel unpacker in Run-3 HLT menus post-#41632 #42410

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e2102/34035/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e2102/34035/git-merge-result

Build

I found compilation error when building:

>> Compiling scram_skylake-avx512 /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_SKYLAKEAVX512_X_2023-07-30-2300/src/DQMServices/Core/src/LegacyIOHelper.cc
>> Compiling scram_skylake-avx512 /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_SKYLAKEAVX512_X_2023-07-30-2300/src/DQMServices/Core/src/MonitorElement.cc
>> Compiling scram_skylake-avx512 /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_SKYLAKEAVX512_X_2023-07-30-2300/src/DQMServices/Core/src/QReport.cc
>> Compiling scram_skylake-avx512 /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_SKYLAKEAVX512_X_2023-07-30-2300/src/DQMServices/Core/src/QTest.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_SKYLAKEAVX512_X_2023-07-30-2300/src/DQMServices/Core/src/ROOTFilePB.pb.cc:4:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_SKYLAKEAVX512_X_2023-07-30-2300/src/DQMServices/Core/interface/ROOTFilePB.pb.h:12:2: error: #error This file was generated by a newer version of protoc which is
   12 | #error This file was generated by a newer version of protoc which is
      |  ^~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_SKYLAKEAVX512_X_2023-07-30-2300/src/DQMServices/Core/interface/ROOTFilePB.pb.h:13:2: error: #error incompatible with your Protocol Buffer headers. Please update
   13 | #error incompatible with your Protocol Buffer headers. Please update
      |  ^~~~~


[iarspider]

please test with cms-sw/cmsdist#8565 for CMSSW_13_3_SKYLAKEAVX512_X

[smuzaffar]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e2102/34046/summary.html
COMMIT: c7084d7
CMSSW: CMSSW_13_3_X_2023-08-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42446/34046/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially added 11 lines to the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3150821
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3150796
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[iarspider]

@smuzaffar should I restart the relvals job? The compilation (for default release) was successful, as were unit tests (but I don't now if that code is covered by unit tests)

[smuzaffar]

yes you can restart the relval input job directly via jenkins

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e2102/34046/summary.html
COMMIT: c7084d7
CMSSW: CMSSW_13_3_X_2023-08-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42446/34046/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 11 lines to the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3150821
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3150796
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e2102/34045/summary.html
COMMIT: c7084d7
CMSSW: CMSSW_13_3_SKYLAKEAVX512_X_2023-07-30-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42446/34045/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @iarspider [GCC13] Add include of cstdint in more places #42392
• @perrotta Maybe remove build warning in TrackerMap, but at least clean it up #42373
• @bsunanda Phase2-TB71 Add a new scenario to evaluate the August 2023 HGCal Test Beam #42429
• @silviodonato sort by pt only good-quality tracks #42428
• @bsunanda Phase2-hgx342C Modify the tester to check correctly the wafer ID from position for HGCal #42438
• @fwyzard Replace the SFINAE check with static_assert #42425
• @caruta Removal of StringCutObjectSelector from Muon trigger DQM #42437
• @fabiocos MTD validation: downgrade warning in BTL local reco validation #42432
• @bsunanda Phase2-sim145 Study the difference in SD's between DDD and DD4hep for Phase2 scenarios #42420
• @smuzaffar [DBG] Fix comparison of integer expressions of different signedness #42405
• @iarspider Code changes for Protobuf 3.21.9 and TensorFlow 2.12 #42228
• @missirol fix configuration of GPU Pixel unpacker in Run-3 HLT menus post-#41632 #42410
• @mmusich TrackerAlignment PI: Support pixel only comparisons #42449
• @smuzaffar Use TCMalloc instead of JeMalloc for cmsRun #42440
• @cms-sw Update TF to 2.12 (backport from IB/CMSSW_13_2_X/g13 branch) cmsdist#8565
• @cms-sw SCRAMV2: Do not create CMS_PAtH/etc/scramrc files which are taken care by SCRAmv1 cmsdist#8622

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e2102/34045/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e2102/34045/git-merge-result

Comparison Summary

Summary:

• You potentially removed 26161 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 73012 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3150821
• DQMHistoTests: Total failures: 159431
• DQMHistoTests: Total nulls: 236
• DQMHistoTests: Total successes: 2991132
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -10375.471 KiB( 47 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): -311.949 KiB DQM/TimerService
• DQMHistoSizes: changed ( 10024.0,... ): -244.914 KiB DQM/TimerService
• DQMHistoSizes: changed ( 10224.0 ): 0.063 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): -0.293 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 136.731,... ): -244.922 KiB DQM/TimerService
• DQMHistoSizes: changed ( 136.7611,... ): -244.910 KiB DQM/TimerService
• DQMHistoSizes: changed ( 139.001 ): -311.965 KiB DQM/TimerService
• DQMHistoSizes: changed ( 250202.181 ): -0.598 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.117 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 4.53 ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 7.3 ): ...
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: found differences in 16 / 46 workflows

[mandrenguyen]

There's a lot of failed comparisons, which seems surprising for a fix to a compiler warning.
Was that expected?

[smuzaffar]

@mandrenguyen , please note that #42446 (comment) is for skylake IBs so yes those differences are expected. You should be looking in to #42446 (comment) for production IB comparison

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1