-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TrackerAlignment PI: Support pixel only comparisons #42449
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42449/36457
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
aah, I was starting to miss these |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge |
PR description:
It is sometimes more convenient and faster (especially for the PCL) to compare two Tracker Alignment payloads only in the Pixel components. This PR supports this option by adding a new template to
TrackerAlignmentCompareAll
in order to limit the number of IDs looked at (ifdoOnlyPixel
those that have subdetId > 2 are discarded).Also added a unit test for the functionality.
PR validation:
Privately run the unit test, successfully.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A