Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrackerAlignment PI: Support pixel only comparisons #42449

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 2, 2023

PR description:

It is sometimes more convenient and faster (especially for the PCL) to compare two Tracker Alignment payloads only in the Pixel components. This PR supports this option by adding a new template to TrackerAlignmentCompareAll in order to limit the number of IDs looked at (if doOnlyPixel those that have subdetId > 2 are discarded).
Also added a unit test for the functionality.

PR validation:

Privately run the unit test, successfully.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42449/36457

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2023

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CondCore/AlignmentPlugins (db)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Aug 2, 2023

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad1bb7/34039/summary.html
COMMIT: 3b065fb
CMSSW: CMSSW_13_3_X_2023-08-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42449/34039/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 14234.014234.0_TTbar_14TeV+2023FSPU/step2_TTbar_14TeV+2023FSPU.log

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150821
  • DQMHistoTests: Total failures: 110
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3150689
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Aug 2, 2023

-1
Failed Tests: RelVals-INPUT

aah, I was starting to miss these

@tvami
Copy link
Contributor

tvami commented Aug 2, 2023

+1

  • dedicated unit test passed
  • relval input test failure are not relevant

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 2, 2023

+1

@perrotta
Copy link
Contributor

perrotta commented Aug 2, 2023

merge

@cmsbuild cmsbuild merged commit 77fd609 into cms-sw:master Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants