Use C++20 with more packages #8558
Conversation
|
A new Pull Request was created by @iarspider for branch IB/CMSSW_13_2_X/g12_cpp20. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
|
please test for CMSSW_13_2_CPP20_X |
professor2-ppc64-flag-change.patch
Outdated
| @@ -20,7 +20,7 @@ index adf3b19..fabdbf0 100644 | |||
| depends=glob("../include/*.h"), | |||
| include_dirs=[incdir, os.path.join(srcdir, "pyext", "professor2")], | |||
| - extra_compile_args="-std=c++11 -O3 -Wno-unused-but-set-variable -Wno-sign-compare".split(), | |||
| + extra_compile_args="-std=c++11 -O3 -mcpu=native -Wno-unused-but-set-variable -Wno-sign-compare".split(), | |||
| + extra_compile_args="-std=c++20 -O3 -mcpu=native -Wno-unused-but-set-variable -Wno-sign-compare".split(), | |||
There was a problem hiding this comment.
@iarspider , may be for cpp std we just patch the Makefile using perl/sed comamnd e.g.
#Make sure the default c++sdt stand is c++11 in Makefile
grep -q 'std=c++11' Makefile
#Change c++ std to %{cms_cxx_standard}
sed -e 's|-std=c++11|-std=c++%{cms_cxx_standard}|' Makefile
|
Pull request #8558 was updated. |
|
please test for CMSSW_13_2_CPP20_X |
|
Pull request #8558 was updated. |
|
please test for CMSSW_13_2_CPP20_X |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca0d3f/33299/summary.html External BuildI found compilation error when building: [ 65%] Linking CXX executable ../gnu_12.3_cxx20_64_relwithdebinfo/test_join_node [ 65%] Built target test_join_node [ 66%] Linking CXX executable ../gnu_12.3_cxx20_64_relwithdebinfo/test_eh_flow_graph [ 66%] Built target test_eh_flow_graph make: *** [Makefile:166: all] Error 2 error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.adXj3K (%build) RPM build errors: line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+tbb+v2021.9.0-cf0e1f5166ce7b9d664b6a9dff370f5f Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.adXj3K (%build) |
|
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: >> Subsystem RecoRomanPot built >> Subsystem SimRomanPot built Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestKernelROCmAsync/libalpakaTestKernelROCmAsync_rocm.a to productstore area: cp: cannot stat 'tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestKernelROCmAsync/libalpakaTestKernelROCmAsync_rocm.a': No such file or directory >> Deleted: tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestKernelROCmAsync/libalpakaTestKernelROCmAsync_rocm.a gmake: *** [config/SCRAM/GMake/Makefile.rules:1793: tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestKernelROCmAsync/libalpakaTestKernelROCmAsync_rocm.a] Error 1 Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/ROCmUtilities/bin/rocmComputeCapabilities/librocmComputeCapabilities_rocm.a to productstore area: Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/ROCmUtilities/bin/rocmIsEnabled/librocmIsEnabled_rocm.a to productstore area: Copying tmp/el8_amd64_gcc12/src/HeterogeneousTest/CUDADevice/src/HeterogeneousTestCUDADevice/libHeterogeneousTestCUDADevice_nv.a to productstore area: Copying tmp/el8_amd64_gcc12/src/HeterogeneousTest/CUDAKernel/src/HeterogeneousTestCUDAKernel/libHeterogeneousTestCUDAKernel_nv.a to productstore area: Copying tmp/el8_amd64_gcc12/src/HeterogeneousTest/CUDAWrapper/src/HeterogeneousTestCUDAWrapper/libHeterogeneousTestCUDAWrapper_nv.a to productstore area: |
pip/requirements.txt
Outdated
| @@ -214,16 +216,16 @@ notebook-shim==0.2.2 | |||
| numexpr==2.8.4 | |||
| # setuptools version <64 is needed by numpy: https://github.com/pypa/setuptools/issues/3549 | |||
| # NO_AUTO_UPDATE: update together with tensorflow | |||
| numpy==1.23.5 | |||
| numpy==1.24.3 | |||
There was a problem hiding this comment.
does this work with current version of TF?
There was a problem hiding this comment.
With 2.6.4? IIRC, no.
|
Pull request #8558 was updated. |
|
Pull request #8558 was updated. |
|
Pull request #8558 was updated. |
cmsbuild
added
tests-started
tests-rejected
and removed
tests-pending
requires-external
tests-started
labels
|
Pull request #8558 was updated. |
|
please test for CMSSW_13_3_CPP20_X |
|
lets merge it |
|
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: >> Leaving Package FWCore/Version >> Package FWCore/Version built Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestKernelROCmAsync/libalpakaTestKernelROCmAsync_rocm.a to productstore area: cp: cannot stat 'tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestKernelROCmAsync/libalpakaTestKernelROCmAsync_rocm.a': No such file or directory >> Deleted: tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestKernelROCmAsync/libalpakaTestKernelROCmAsync_rocm.a gmake: *** [config/SCRAM/GMake/Makefile.rules:1793: tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestKernelROCmAsync/libalpakaTestKernelROCmAsync_rocm.a] Error 1 Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/ROCmUtilities/bin/rocmComputeCapabilities/librocmComputeCapabilities_rocm.a to productstore area: Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/ROCmUtilities/bin/rocmIsEnabled/librocmIsEnabled_rocm.a to productstore area: Copying tmp/el8_amd64_gcc12/src/HeterogeneousTest/CUDADevice/src/HeterogeneousTestCUDADevice/libHeterogeneousTestCUDADevice_nv.a to productstore area: Copying tmp/el8_amd64_gcc12/src/HeterogeneousTest/CUDAKernel/src/HeterogeneousTestCUDAKernel/libHeterogeneousTestCUDAKernel_nv.a to productstore area: Copying tmp/el8_amd64_gcc12/src/HeterogeneousTest/ROCmDevice/src/HeterogeneousTestROCmDevice/libHeterogeneousTestROCmDevice_rocm.a to productstore area: |
No description provided.