Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf/grpc: patch applied for deprecated std::iterator #8367

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

smuzaffar
Copy link
Contributor

No description provided.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2023

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_1_X/g12.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

+externals
at least this fixes the external build errors for gcc12. Lets get this merge and build and IB for gcc12

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2023

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_1_X/g12 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2023

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8bbdb/31153/summary.html
COMMIT: 6b8ba51
CMSSW: CMSSW_13_1_X_2023-03-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8367/31153/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

Entering library rule at RecoTBCalo/HcalTBTools
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-01-1100/src/RecoTBCalo/HcalTBTools/src/HcalTBTriggerFilter.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-01-1100/src/RecoTBCalo/HcalTBTools/src/SealModule.cc
>> Building edm plugin tmp/el8_amd64_gcc12/src/RecoTBCalo/HcalTBTools/src/RecoTBCaloHcalTBTools/libRecoTBCaloHcalTBTools.so
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.2.0-f8ec77b592790702d83afb7106a458e3/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.2.1/../../../../x86_64-redhat-linux-gnu/bin/ld: cannot find -lTBDataFormatsHcalTBObjects
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc12/src/RecoTBCalo/HcalTBTools/src/RecoTBCaloHcalTBTools/libRecoTBCaloHcalTBTools.so] Error 1
Leaving library rule at RecoTBCalo/HcalTBTools
>> Leaving Package RecoTBCalo/HcalTBTools
>> Package RecoTBCalo/HcalTBTools built
>> Entering Package TBDataFormats/HcalTBObjects


@smuzaffar smuzaffar deleted the gcc12-fix-std-iterator branch March 14, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants