MTD reconstruction and validation: validation and debugging information for track - MTD matching studies

[fabiocos]

PR description:

This PR is a follow-up of #42178 , it adds a few histograms to MTD validation and improves several debugging printouts, to analyse in detail events where the TrackExtenderWithMTD fails to find MTD hits, that are found in a cone around a simple track extrapolation to BTL surface.

PR validation:

Code compiles, runs, and provide detailed debugging printout being actively use for investigation. A few added prolts are shown in https://indico.cern.ch/event/1306288/contributions/5493532/attachments/2683819/4656070/MTDDPG-BTLmatching_20230714.pdf slide 13.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42257/36280

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

• RecoLocalFastTime/FTLRecProducers (upgrade, reconstruction)
• RecoMTD/TrackExtender (upgrade, reconstruction)
• Validation/MtdValidation (dqm)

@micsucmed, @emanueleusai, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @pmandrik, @syuvivida, @nothingface0, @tjavaid, @mandrenguyen, @rvenditti can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a487a/33681/summary.html
COMMIT: a0d1108
CMSSW: CMSSW_13_2_X_2023-07-13-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42257/33681/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 27078 lines to the logs
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3193892
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3193866
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 11.376000000000001 KiB( 47 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 1.543 KiB MTD/Tracks
• DQMHistoSizes: changed ( 23234.0,... ): 0.353 KiB MTD/BTL
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[fabiocos]

I need to downgrade a new warning, this is interesting for debugging but not for regular production

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42257/36287

• This PR adds an extra 52KB to repository

[cmsbuild]

Pull request #42257 was updated. @micsucmed, @emanueleusai, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @pmandrik, @syuvivida, @nothingface0, @tjavaid, @mandrenguyen, @rvenditti can you please check and sign again.

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a487a/33691/summary.html
COMMIT: 2ad4bd6
CMSSW: CMSSW_13_2_X_2023-07-13-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42257/33691/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 26376 lines to the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3193908
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3193885
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 11.376000000000001 KiB( 47 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 1.543 KiB MTD/Tracks
• DQMHistoSizes: changed ( 23234.0,... ): 0.353 KiB MTD/BTL
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[srimanob]

+Upgrade

This PR adds few more histograms for MTD, and update debugging printout as mention in the PR description. No change is expected on simulation and reconstruction.

[fabiocos]

@cms-sw/reconstruction-l2 could you please comment or sign? The changes in the reco area are quite trivial, and not affecting regular processing

[clacaputo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1