Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT628] Updated root to tip of branch root628 #8290

Conversation

iarspider
Copy link
Contributor

No description provided.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2023

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_0_X/root628.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2023

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0950d/30415/summary.html
COMMIT: a3a1d44
CMSSW: CMSSW_13_0_ROOT628_X_2023-02-05-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8290/30415/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

@@@@ ----> OK  EDM Class Version 
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libAlignmentOfflineValidation.so
>> Checking EDM Class Transients in libAlignmentLaserAlignment.so
Suggestion: You can run 'scram build updateclassversion' to generate src/Calibration/HcalCalibAlgos/src/classes_def.xml.generated with updated ClassVersion
gmake: *** [tmp/el8_amd64_gcc11/edm_checks/libCalibrationHcalCalibAlgos.so] Error 1
>> Checking EDM Class Version for src/AnalysisDataFormats/EWK/src/classes_def.xml in libAnalysisDataFormatsEWK.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libPhysicsToolsSelectorUtils.so
@@@@ ----> OK  EDM Class Version 
Error in : version mismatch, /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_ROOT628_X_2023-02-05-2300/lib/el8_amd64_gcc11/libPhysicsToolsPatUtils.so = 62799, ROOT = 62801


@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2023

Pull request #8290 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2023

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0950d/30422/summary.html
COMMIT: 5d5cd41
CMSSW: CMSSW_13_0_ROOT628_X_2023-02-05-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8290/30422/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

@@@@ ----> OK  EDM Class Version 
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libPhysicsToolsFWLite.so
>> Checking EDM Class Transients in libPhysicsToolsSelectorUtils.so
Suggestion: You can run 'scram build updateclassversion' to generate src/Fireworks/FWInterface/src/classes_def.xml.generated with updated ClassVersion
gmake: *** [tmp/el8_amd64_gcc11/edm_checks/libFireworksFWInterface.so] Error 1
Error in : version mismatch, /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_0_ROOT628_X_2023-02-05-2300/lib/el8_amd64_gcc11/libPhysicsToolsPatUtils.so = 62799, ROOT = 62801
Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week1/el8_amd64_gcc11/cms/cmssw/CMSSW_13_0_ROOT628_X_2023-02-05-2300/src/FWCore/Utilities/scripts/edmCheckClassVersion", line 181, in 
    raise RuntimeError("failed to load library '"+options.library+"'")
RuntimeError: failed to load library 'libPhysicsToolsPatUtils.so'


@iarspider
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0950d/30433/summary.html
COMMIT: 5d5cd41
CMSSW: CMSSW_13_0_ROOT628_X_2023-02-05-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8290/30433/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0950d/30433/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0950d/30433/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

  • You potentially removed 182 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555495
  • DQMHistoTests: Total failures: 642
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554831
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar merged commit 712a500 into cms-sw:IB/CMSSW_13_0_X/root628 Feb 7, 2023
@iarspider iarspider deleted the root-update-v6-28-00-patches-20230206 branch February 12, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants