Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROOT] Updated root to tip of branch master #5633

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Mar 9, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5075/console Started: 2020/03/09 16:47

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_11_1_X/rootmaster.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

davidlange6 added a commit that referenced this pull request Mar 9, 2020
sync up with #5633
@davidlange6
Copy link
Contributor

hi @mrodozov - apologies my commit was intended as a PR... I've added this change to the modules branch as we wanted some of the commits asap.. if it doesn't go well I'll fix up for tomorrow night

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

+1
Tested at: 6ee8cdb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df245c/5075/summary.html
CMSSW: CMSSW_11_1_ROOT6_X_2020-03-08-0000
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df245c/5075/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680577
  • DQMHistoTests: Total failures: 40
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2680218
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_1_X/rootmaster IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants