Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated root to tip of branch master #6936

Merged
merged 2 commits into from
May 28, 2021
Merged

Updated root to tip of branch master #6936

merged 2 commits into from
May 28, 2021

Conversation

mrodozov
Copy link
Contributor

get latest commits

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_0_X/rootmaster.

@smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b5abc/15288/summary.html
COMMIT: ac2d623
CMSSW: CMSSW_12_0_ROOT6_X_2021-05-24-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6936/15288/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:


-- Configuring incomplete, errors occurred!
See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.25.01-eb23d4cc77e34e4ef916dcf1866cfb4b/build/CMakeFiles/CMakeOutput.log".
See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.25.01-eb23d4cc77e34e4ef916dcf1866cfb4b/build/CMakeFiles/CMakeError.log".
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.5ykk9G (%build)


RPM build errors:
Macro %rpmbuild_libdir defined but not used within scope
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.5ykk9G (%build)

@makortel
Copy link
Contributor

In oneTBB v2021.2.0

$ git grep -i captured_exception
test/tbb/test_task_group.cpp:#if TBB_USE_CAPTURED_EXCEPTION
test/tbb/test_task_group.cpp:    typedef tbb::captured_exception TestException;

which leaves me wondering how exactly this error could be triggered?

@mrodozov
Copy link
Contributor Author

I'm reading that commit
root-project/root@a0b5e3d
and I wonder if this logic is correct

@makortel
Copy link
Contributor

From the discussion in root-project/root#8169 the PR was motivated by TBB 2018, and indeed there git grep shows many hits. So something that has been removed since.

@makortel
Copy link
Contributor

The logic is most certainly not correct, TBB 2021.2 does not even have tbb/tbb_config.h.

@makortel makortel mentioned this pull request May 26, 2021
Merged
hahnjo added a commit to hahnjo/root that referenced this pull request May 26, 2021
@hahnjo
Tweak CMake check for oneTBB
213f4a4 
Versions newer than 2021 don't have the header tbb/tbb_config.h,
see cms-sw/cmsdist#6936
@hahnjo hahnjo mentioned this pull request May 26, 2021
Merged
@mrodozov
Copy link
Contributor Author

hahjo figured whats wrong and is pushing it for a fix

hahnjo added a commit to hahnjo/root that referenced this pull request May 27, 2021
@hahnjo
Fix CMake configuration and build with oneTBB
d5857c6 
Versions newer than 2021 don't have the header tbb/tbb_config.h,
see cms-sw/cmsdist#6936
oshadura pushed a commit to root-project/root that referenced this pull request May 27, 2021
@hahnjo @oshadura
Fix CMake configuration and build with oneTBB
f30096e 
Versions newer than 2021 don't have the header tbb/tbb_config.h,
see cms-sw/cmsdist#6936
@cmsbuild
Copy link
Contributor

Pull request #6936 was updated.

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b5abc/15350/summary.html
COMMIT: 5cf342b
CMSSW: CMSSW_12_0_ROOT6_X_2021-05-26-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6936/15350/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b5abc/15350/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b5abc/15350/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test EcalADCToGeV_update_test had ERRORS
---> test EcalDCS_O2O_test had ERRORS
---> test EcalTPGBadStripStatus_O2O_test had ERRORS
---> test EcalTPGCrystalStatus_O2O_test had ERRORS
and more ...

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2650486
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2650457
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@mrodozov
Copy link
Contributor Author

please test with cms-sw/cmssw#33875

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b5abc/15380/summary.html
COMMIT: 5cf342b
CMSSW: CMSSW_12_0_X_2021-05-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/6936/15380/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b5abc/15380/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b5abc/15380/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test_MuonGeometryDBConverter had ERRORS
---> test test_PixelBaryCentreTool had ERRORS
---> test testAlignmentOfflineValidation had ERRORS
---> test testHcalPulseContainmentTest had ERRORS
and more ...

RelVals

  • 4.534.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log
  • 25.025.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step1_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log
  • 7.37.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18/step1_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
Expand to see more relval errors ...

RelVals-INPUT

  • 4.364.36_WElSkim2011B+WElSkim2011B+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT/step2_WElSkim2011B+WElSkim2011B+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT.log
  • 4.44.4_RunMinBias2012A+RunMinBias2012A+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunMinBias2012A+RunMinBias2012A+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log
  • 4.264.26_ZMuSkim2011A+ZMuSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT/step2_ZMuSkim2011A+ZMuSkim2011A+HLTDSKIM+RECODR1reHLT+HARVESTDR1reHLT.log
Expand to see more relval errors ...

AddOn Tests

  • fastsimcmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Fri May 28 21:25:11 2021-date Fri May 28 21:24:05 2021 s - exit: 34304
  • pat1cmsRun /data/cmsbld/jenkins/workspace/ib-run-pr-addon/CMSSW_12_0_X_2021-05-27-2300/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Fri May 28 21:24:37 2021-date Fri May 28 21:24:08 2021 s - exit: 34304
  • hlt_data_Fake2cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake2 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Fri May 28 21:25:23 2021-date Fri May 28 21:24:13 2021 s - exit: 34304
Expand to see more addon errors ...

@mrodozov mrodozov merged commit 37d3908 into cms-sw:IB/CMSSW_12_0_X/rootmaster May 28, 2021
pzhristov pushed a commit to alisw/root that referenced this pull request Aug 27, 2021
@hahnjo
Fix CMake configuration and build with oneTBB
f06124c 
Versions newer than 2021 don't have the header tbb/tbb_config.h,
see cms-sw/cmsdist#6936
@cmsbuild cmsbuild mentioned this pull request Nov 9, 2021
Merged
@cmsbuild cmsbuild mentioned this pull request May 16, 2022
Merged
@cmsbuild cmsbuild mentioned this pull request Aug 16, 2022
Merged
@cmsbuild cmsbuild mentioned this pull request Jun 7, 2023
Closed
@cmsbuild cmsbuild mentioned this pull request Aug 7, 2023
Merged
@cmsbuild cmsbuild mentioned this pull request Sep 28, 2023
Closed
@cmsbuild cmsbuild mentioned this pull request Oct 23, 2023
Merged
@cmsbuild cmsbuild mentioned this pull request Nov 22, 2023
Merged
@cmsbuild cmsbuild mentioned this pull request Feb 2, 2024
Merged
This was referenced Feb 19, 2024
Closed
Merged
@cmsbuild cmsbuild mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures requires-external tests-rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrodozov @cmsbuild @makortel