Require TBB without captured exceptions #8169
Conversation
|
Starting build on |
Related to ROOT-10636
If TBB_USE_CAPTURED_EXCEPTION is set, tbb_config.h checks if the support for exact exception propagation is available. Related to ROOT-10636
hahnjo
force-pushed
the
tbb-captured-exceptions
branch
from
a5c98c7 to
c849f8e
Compare
|
Starting build on |
There was a problem hiding this comment.
@hahnjo thanks a lot, I wanted to ask if TBB_USE_CAPTURED_EXCEPTION is limited to particular version of TBB? I don't know where we cant test it, there is probably no suitable node is available in CI, so I trust you that you manage to fix it in your setup :) Please feel free to reassign https://sft.its.cern.ch/jira/browse/ROOT-10636 to yourself!
My understanding is that |
| if(TBB_FOUND) | ||
| set(CMAKE_REQUIRED_INCLUDES "${TBB_INCLUDE_DIRS}") | ||
| check_cxx_source_compiles(" | ||
| #include <tbb/tbb_config.h> |
There was a problem hiding this comment.
oneTBB 2021.2 does not have this header, so this check fails falsely claiming TBB being built with "tbb::captured_exception" that doesn't even exist anymore in that version.
(found out in cms-sw/cmsdist#6936)
There was a problem hiding this comment.
Thanks for testing and reporting. Indeed, oneTBB doesn't have the header anymore nor the "captured exceptions" thing, so #8239 skips the test under those conditions.
@oshadura our FindTBB.cmake cannot detect versions of newer TBBs because, guess what, they don't have the header tbb/tbb_stddef.h either. I was first checking TBB_VERSION, but that's empty in such case. Probably somebody with proper CMake skills should take a look and make the detection work properly...
There was a problem hiding this comment.
@hahnjo thanks a lot for fix! could you please open a GH issue/improvement to revisit FindTBB.cmake? I will recheck it ASAP
Related to ROOT-10636