-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD simulation: update trackId for BTL PSimHits #42455
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42455/36459
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages:
@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27da2b/34051/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR provides an update of the work originally proposed in #41318 , and is documented in the presentation at the MTD DPG https://indico.cern.ch/event/1311014/contributions/5519119/attachments/2691938/4671605/MTDDPG-SIMtruth_20230728.pdf . Its purpose is on one hand to preserve the link between a
PSimHit
in BTL andSimTrack
ids stored in the event, on the other discriminate (as much as possible) between BTL hits directly produced by primary tracks initially crossing crystals and by other possible tracks: secondaries from interactions in tracker that are not stored in the event history, hits by looping tracks that exited BTL and entered it again (not only charged tracks spiralizing in magnetic field, but also neutrals bouncing on material can have such a pattern), and hits from particles back-scattered into BTL from interactions with calorimeters (mostly ECAL).In order to store such information while leaving unchanged the basic structure of the
PSimHit
object, the track id information stored in the hit is expanded with an offset large enough not to interfere with the genuine expected number of particles even in a quite large event (like for instance high pT QCD jets).The categorization is based on a monitoring of volume boundary crossing in
Phase2SteppingAction
, coping with the current Phase2 geometry structure, and on track classification inMCTruthUtil
at the beginning of the track processing.PR validation:
Code compiles, runs, and a detailed MessageLogger and event content hit analysis shows the desired behaviour. A DQM comparison on 10k MinBias events with and without this PR does not show any statistically significant effect, but for the multiplicity of tracks per crystal, which depends clearly on the track identifier of the hits.